Disables response logging as a default #42353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if any of the following were true, we would log HTTP responses. - `logging.json` was set - `logging.dest` was set - `TTY` was detected The logging format should not dictate what is logged Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added
review
release_note:breaking
Team:Operations
|
Pinging @elastic/kibana-operations |
jbudz
approved these changes
Jul 31, 2019
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Aug 15, 2019
Previously, if any of the following were true, we would log HTTP responses. - `logging.json` was set - `logging.dest` was set - `TTY` was detected The logging format should not dictate what is logged Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if any of the following were true, we would log HTTP responses.
logging.jsonwas setlogging.destwas setTTYwas detectedThe logging format should not dictate what is logged
Release Note: Responses are never logged by default. Previously, responses would be logged if either
logging.jsonwas true,logging.destwas specified, or aTTYwas detected. To restore the previous behavior set logging.events.response=*` in kibana.yml.