Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move vault setup into repo so all ci logic is in the repo #42642

Merged
merged 5 commits into from Aug 6, 2019

Conversation

@spalger
Copy link
Member

commented Aug 5, 2019

In order to improve the windows/linux compatibility, this moves the vault interactions from the CI config files into the repo.

@spalger spalger requested a review from tylersmalley Aug 5, 2019

@spalger spalger requested a review from elastic/kibana-operations as a code owner Aug 5, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2019

@tylersmalley
Copy link
Member

left a comment

LGTM - I assume we're getting this in prior to setting VAULT_SECRET_ID for the job.

spalger added some commits Aug 5, 2019

@spalger

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Yeah, this logic is already executing on CI before this script runs, which is why VAULT_SECRET_ID is unset by the time it runs. Once this is merged I'll be testing in a local Jenkins to make sure that the new secrets will be initialized appropriately before removing the current script in CI config.

@elasticmachine

This comment was marked as off-topic.

Copy link
Collaborator

commented Aug 5, 2019

@elasticmachine

This comment was marked as outdated.

Copy link
Collaborator

commented Aug 5, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 6, 2019

@spalger spalger merged commit 9ddbd84 into elastic:master Aug 6, 2019

50 checks passed

API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Firefox smoke test node scripts/functional_tests --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-firefoxSmoke/node/linux-immutable/install/kibana --include-tag smoke --config test/functional/config.firefox.js
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup1/node/linux-immutable/install/kibana --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup10/node/linux-immutable/install/kibana --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup2/node/linux-immutable/install/kibana --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup3/node/linux-immutable/install/kibana --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup4/node/linux-immutable/install/kibana --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup5/node/linux-immutable/install/kibana --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup6/node/linux-immutable/install/kibana --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup7/node/linux-immutable/install/kibana --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup8/node/linux-immutable/install/kibana --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup9/node/linux-immutable/install/kibana --include-tag ciGroup9
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Mocha yarn test
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack firefox smoke test node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-firefoxSmoke/node/linux-immutable/install/kibana --include-tag smoke --config test/functional/config.firefox.js
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
prbot:outdated run `node scripts/update_prs 42642` to update
prbot:release note labels
sasslint node scripts/sasslint
Details

spalger added a commit to spalger/kibana that referenced this pull request Aug 6, 2019

move vault setup into repo so all ci logic is in the repo (elastic#42642
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

spalger added a commit to spalger/kibana that referenced this pull request Aug 6, 2019

move vault setup into repo so all ci logic is in the repo (elastic#42642
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

spalger added a commit to spalger/kibana that referenced this pull request Aug 6, 2019

move vault setup into repo so all ci logic is in the repo (elastic#42642
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

spalger added a commit to spalger/kibana that referenced this pull request Aug 6, 2019

move vault setup into repo so all ci logic is in the repo (elastic#42642
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

# Conflicts:
#	.ci/run.sh

spalger added a commit to spalger/kibana that referenced this pull request Aug 6, 2019

move vault setup into repo so all ci logic is in the repo (elastic#42642
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

# Conflicts:
#	.ci/run.sh

spalger added a commit to spalger/kibana that referenced this pull request Aug 6, 2019

move vault setup into repo so all ci logic is in the repo (elastic#42642
)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

# Conflicts:
#	.ci/run.sh
@spalger

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

7.x/7.4: 888b575
7.3: 0740aa3
7.2: 17b6727
6.8: 2eff7f9

spalger added a commit that referenced this pull request Aug 6, 2019

move vault setup into repo so all ci logic is in the repo (#42642) (#…
…42654)

* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR

# Conflicts:
#	.ci/run.sh

@spalger spalger removed v7.0.2 v7.1.2 labels Aug 6, 2019

@spalger spalger deleted the spalger:implement/local-vault-interactions branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.