Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI@13.3.0 #42858

Merged
merged 9 commits into from Aug 20, 2019

Conversation

@snide
Copy link
Contributor

commented Aug 7, 2019

Summary

Upgrades from 13.1.1. For outside reviews, updates are only to snap files and some i18n work.

13.3.0

  • Added i18n tokens to EuiSuperDatePicker and EuiSuperUpdateButton

13.2.0

  • Converted EuiStep, EuiSteps, EuiStepHorizontal, EuiStepsHorizontal, and EuiSubSteps to Typescript (#2186)

Bug fixes

  • Fixed EuiBadge truncation and auto-applied title attribute with innerText (#2190)
  • Remove exported TypeScript type and interface exports from built artifacts when they originate from node_modules (#2191)
  • Fixed EuiBadge truncation in IE and for the global filters pattern (#2194)
  • Fixed alignment of long titles in EuiStep (#2186)
  • Fixed the TS defs for EuiFilterSelectItem (#2192)
  • Added missing TS defs for EuiTextArea (#2201)

@snide snide requested a review from chandlerprall Aug 7, 2019

@snide snide requested a review from elastic/apm-ui as a code owner Aug 7, 2019

@snide

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

cc @bmcconaghy Feel free to push against this as you need. @chandlerprall looks like some TS conversions, but snaps ran fine.

@chandlerprall
Copy link
Contributor

left a comment

package, snapshot, and yarn.lock changes LGTM

@snide snide requested a review from elastic/kibana-platform as a code owner Aug 7, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Aug 7, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Aug 7, 2019

@sqren

sqren approved these changes Aug 7, 2019

@snide

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

jenkins test this

@snide

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

jenkins retest

@elasticmachine

This comment has been minimized.

Copy link

commented Aug 7, 2019

"euiSuperSelect.screenReaderAnnouncement": [Function],
"euiSuperSelectControl.selectAnOption": [Function],
"euiSuperUpdateButton.cannotUpdateTooltip": "Cannot update",

This comment has been minimized.

Copy link
@restrry

restrry Aug 8, 2019

Member

@elastic/kibana-platform do we need this test? testing translation format is not a task for service test. we can check that some keys are present in the mapping object.

bmcconaghy added some commits Aug 8, 2019

Revert "fixing typo"
This reverts commit d25d689.
@bmcconaghy

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@restrry mind taking another look?

@restrry

restrry approved these changes Aug 8, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Aug 8, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Aug 8, 2019

@chandlerprall

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

@spalger is investigating the CI failure. It appears that the Fixed EuiBadge truncation and auto-applied title attribute with innerText bugfix exposed some dependency misconfiguration in the CI build/test setup.

@bmcconaghy

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@spalger any progress on this? I would like to get this in before FF for 7.4 as it includes a localization fix for the timepicker.

@snide

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Reminder that chandler will be out this week on vacation. @thompsongl can help out on the EUI side @spalger.

@thompsongl

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Anything I can do to help here, @spalger?

@spalger

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Sorry folks, github notifications have snowballed a bit, taking a look at this now

@spalger

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Alright, the issue is that the plugins in test/plugin_functional/plugins are pulling in the React install from the Kibana source, and all the rest of Kibana is using the React install from the distributable, which is an issue because we can't have multiple versions of React on the same page.

We can probably fix this by copying the testing plugins out of the Kibana directory and into the installation, but that's going to take some changes to @kbn/test. I'll see what I can do about getting those changes in.

@thompsongl

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Multiple versions of React is what I suspected from the error, but it seems crazy we haven't hit this yet given we've been using hooks for months now.

Thanks, @spalger

@joshdover

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

@spalger Need any help on this? EUI has been bumped to 13.4.0 which I'd like to get in to solve a problem for the AppService PR (#41007)

@spalger spalger force-pushed the snide:eui/13.3.0 branch 2 times, most recently from 919e99a to a6afbee Aug 20, 2019

@elasticmachine

This comment was marked as outdated.

Copy link

commented Aug 20, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Aug 20, 2019

💚 Build Succeeded

@spalger
Copy link
Member

left a comment

LGTM

@snide snide merged commit b0a4181 into elastic:master Aug 20, 2019

53 checks passed

API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Firefox smoke test node scripts/functional_tests --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-firefoxSmoke/node/linux-immutable/install/kibana --include-tag smoke --config test/functional/config.firefox.js
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Kibana visual regression tests yarn run percy exec node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-visualRegression/node/linux-immutable/install/kibana --config test/visual_regression/config.ts
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup1/node/linux-immutable/install/kibana --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup10/node/linux-immutable/install/kibana --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup2/node/linux-immutable/install/kibana --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup3/node/linux-immutable/install/kibana --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup4/node/linux-immutable/install/kibana --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup5/node/linux-immutable/install/kibana --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup6/node/linux-immutable/install/kibana --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup7/node/linux-immutable/install/kibana --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup8/node/linux-immutable/install/kibana --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup9/node/linux-immutable/install/kibana --include-tag ciGroup9
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Mocha yarn test
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack firefox smoke test node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-firefoxSmoke/node/linux-immutable/install/kibana --include-tag smoke --config test/functional/config.firefox.js
Details
X-Pack visual regression tests yarn run percy exec node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-visualRegression/node/linux-immutable/install/kibana --config test/visual_regression/config.js
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
percy/kibana Visual review automatically approved, no visual changes found.
Details
prbot:outdated run `node scripts/update_prs 42858` to update
prbot:release note labels
sasslint node scripts/sasslint
Details

@snide snide deleted the snide:eui/13.3.0 branch Aug 20, 2019

snide added a commit to snide/kibana that referenced this pull request Aug 20, 2019

snide added a commit that referenced this pull request Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.