Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Display all errors in child transactions/spans in trace overview #44274

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@dgieselaar
Copy link
Contributor

commented Aug 28, 2019

Closes #42357.

@dgieselaar dgieselaar requested a review from elastic/apm-ui as a code owner Aug 28, 2019

}

export const ErrorCountBadge: React.SFC<Props> = ({
errorCount = 0,
transaction,
verbose
verbose,
link = true

This comment has been minimized.

Copy link
@sqren

sqren Aug 28, 2019

Member

This component (ErrorCountBadge) is only used in two places:

https://github.com/elastic/kibana/blob/70f03018f38138356274d47b30d7e7bdd170676e/x-pack/legacy/plugins/apm/public/components/app/TransactionDetails/Transaction/StickyTransactionProperties.tsx

<ErrorCountBadge
  errorCount={errorCount}
  transaction={transaction}
  verbose
  link={false}
/>

and

<ErrorCountBadge
errorCount={errorCount}
transaction={item.transaction}
/>

It doesn't look like they have anything else in common except for this:

const errorCountBadge = (
  <EuiBadge color={euiThemeLight.euiColorDanger} {...linkProps}>
    {errorCount}
  </EuiBadge>
);

Probably better to simplify the component to just that and move the link-specific stuff into waterfallItem.tsx and the label into StickyTransactionProperties.tsx

This comment has been minimized.

Copy link
@dgieselaar

dgieselaar Sep 2, 2019

Author Contributor

@sqren this should be fixed now, I think.

@spalger

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

@dgieselaar dgieselaar force-pushed the dgieselaar:correct-sample-error-count branch from adc0268 to b6ef1e7 Aug 29, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

@dgieselaar dgieselaar force-pushed the dgieselaar:correct-sample-error-count branch from b6ef1e7 to 28ce814 Sep 2, 2019

@dgieselaar dgieselaar requested a review from sqren Sep 2, 2019

@sqren
sqren approved these changes Sep 2, 2019
@sqren sqren referenced this pull request Sep 2, 2019
1 of 6 tasks complete
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

@dgieselaar dgieselaar merged commit a886392 into elastic:master Sep 2, 2019

40 checks passed

API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Firefox smoke test node scripts/functional_tests --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/firefoxSmoke/node/linux-immutable/install/kibana --include-tag smoke --config test/functional/config.firefox.js
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup1/node/linux-immutable/install/kibana --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup2/node/linux-immutable/install/kibana --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup3/node/linux-immutable/install/kibana --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup4/node/linux-immutable/install/kibana --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup5/node/linux-immutable/install/kibana --include-tag ciGroup5
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Mocha yarn test
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack firefox smoke test node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/firefoxSmoke/node/linux-immutable/install/kibana --include-tag smoke --config test/functional/config.firefox.js
Details
elasticsearch-ci/docs Build finished.
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
prbot:outdated run `node scripts/update_prs 44274` to update
prbot:release note labels
sasslint node scripts/sasslint
Details

@dgieselaar dgieselaar deleted the dgieselaar:correct-sample-error-count branch Sep 2, 2019

dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Sep 2, 2019
[APM] Display all errors in child transactions/spans in trace overview (
elastic#44274)

* [APM] Display all errors in child transactions/spans in trace overview

Closes elastic#42357.

* Refactor ErrorCountBadge
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Sep 2, 2019
[APM] Display all errors in child transactions/spans in trace overview (
elastic#44274)

* [APM] Display all errors in child transactions/spans in trace overview

Closes elastic#42357.

* Refactor ErrorCountBadge
dgieselaar added a commit that referenced this pull request Sep 2, 2019
[APM] Display all errors in trace overview (#44274) (#44596)
* [APM] Display all errors in child transactions/spans in trace overview

Closes #42357.

* Refactor ErrorCountBadge
dgieselaar added a commit that referenced this pull request Sep 2, 2019
[APM] Display all errors in trace overview (#44274) (#44597)
* [APM] Display all errors in child transactions/spans in trace overview

Closes #42357.

* Refactor ErrorCountBadge

@sqren sqren self-assigned this Sep 10, 2019

@sqren

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

The trace header now shows the total number of errors in the trace. However this has introduced a new edge case (not blocking) that is explained in more detail in #45258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.