Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [APM] More descriptive page titles (#44296) #44570

Closed
wants to merge 1 commit into from

Conversation

@sqren
Copy link
Member

commented Sep 1, 2019

Backports the following commits to 7.x:

  • [APM] More descriptive page titles (#44296)
[APM] More descriptive page titles (#44296)
Instead of using only the text of the last breadcrumb for the page title, use the breadcrumbs to create a reverse list of items (since in the page title we want the most relevant item at the beginning) that are pipe-separated.

This only affects the page titles in APM, since Infra uses a different mechanism for breadcrumbs and page titles.

The implementation doesn't exactly match the discussion on #41456, and there's no truncation, but it should be an improvement.

Also update the tests so that they more accurately reflect the routes actually being used in the app.

Fixes #41456.

@sqren sqren added the backport label Sep 1, 2019

@sqren sqren closed this Sep 1, 2019

@sqren sqren deleted the sqren:backport/7.x/pr-44296 branch Sep 1, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.