Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Test plan proposal #44887

Merged
merged 3 commits into from Sep 9, 2019

Conversation

@sqren
Copy link
Member

commented Sep 5, 2019

This is a proposal for a test plan process. It is intended to be as lightweight as possible while still giving us some structure.
Interested to hear your feedback

x-pack/legacy/plugins/TEST_PLAN.md Outdated Show resolved Hide resolved
- Assign yourself to an issue as you start testing it to avoid duplicate work
- Testing a PR can have two outcomes:
- It worked as expected => Apply `tested-after-ff` label
- It did not work as expected => Create a bug report and link to it from the PR

This comment has been minimized.

Copy link
@graphaelli

graphaelli Sep 5, 2019

Member

should the bug have the label applied as well? The original issue's label should only be added after the bug is resolved.

This comment has been minimized.

Copy link
@sqren

sqren Sep 5, 2019

Author Member

I think the issue created for the bug should have the version label (in this case v7.4.0). But I don't think it makes sense to add in-test-plan since that's only for PRs that have already been merged (and can actually be tested)

This comment has been minimized.

Copy link
@sqren

sqren Sep 5, 2019

Author Member

With regards to the process when a bug is discovered I'm leaning towards still marking the PR as tested with tested-after-ff. Since an issue will be created (which should have high priority) it will eventually lead to a new PR which will end up in the test plan. And having duplicate PRs in the test plan is maybe confusing.

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Pinging @elastic/apm-ui

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Fix version label
Co-Authored-By: Gil Raphaelli <gil@elastic.co>
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

@sqren sqren merged commit 622162d into master Sep 9, 2019

2 of 6 checks passed

prbot:outdated run `node scripts/update_prs 44887` to update, > 48h old
prbot:release version labels All PRs require at least one release version label
elasticsearch-ci/docs Build triggered for merge commit.
Details
kibana-ci Build triggered for merge commit.
Details
CLA All commits in pull request signed
Details
prbot:release note labels

@sqren sqren deleted the apm-test-plan-proposal branch Sep 9, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.