Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to 13.8.1 #45052

Merged
merged 9 commits into from Sep 11, 2019

Conversation

@thompsongl
Copy link
Contributor

commented Sep 6, 2019

eui@13.6.1 eui@13.8.1

  • Many components converted to TypeScript (e.g., EuiButton and Co., EuiTable and Co.)
  • EUI theme and docs for elastic-charts

Snapshot churn is largely due to TS conversions, which express more props (explicit default values instead ofdefaultProps)


13.8.1

Bug fixes

  • Updated TS def for EuiFilterSelect (#2291)
  • Fixed alignment of icons and label in EuiSideNavItem (#2297)
  • Fixed logic in EuiContextMenu to account for index of 0 (#2304)

13.8.0

  • Added href prop to EuiTab and converted to TypeScript (#2275)
  • Created EuiInputPopover component (formally) (#2269)
  • Added docs for using Elastic Charts with EUI (#2209)

Bug fixes

  • Removed extra right side margin in EuiSuperDatePicker (#2236)
  • Fixed incorrect onClick type for EuiButtonEmpty (#2282)
  • Fixed compilation script to remove all TypeScript definition exports from built JS assets (#2279)
  • Fixed output extension for dist charts theme module (#2294)

13.7.0

  • Allow EuiFlexGroup to accept a ref (#2223)

Bug fixes

  • Fixed EuiSuperDatePicker to update asyncInterval.isStopped on a isPaused prop change. (#2250)
  • Converted table, popover, buttons, pagination, outside click detector, focus trap, context menu, and panel to TypeScript (#2212)
  • Fixed EuiStat invalid DOM nesting due to a <p> tag nested within another <p> tag (#2229)
  • Fixed title text of dock/undock icon in EuiNavDrawer (#2261)
thompsongl added 6 commits Sep 6, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

@chandlerprall

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

package.json, snapshot, code, and yarn.lock changes LGTM pending changes for tests

thompsongl added 2 commits Sep 9, 2019

@thompsongl thompsongl changed the title Upgrade EUI to 13.8.0 Upgrade EUI to 13.8.1 Sep 9, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

@thompsongl thompsongl marked this pull request as ready for review Sep 9, 2019

@thompsongl thompsongl requested review from elastic/apm-ui as code owners Sep 9, 2019

@chandlerprall
Copy link
Contributor

left a comment

Changes LGTM!

@weltenwort
Copy link
Contributor

left a comment

LGTM from the infra plugin perspective

@joshdover
Copy link
Member

left a comment

Platform changes good

@snide snide referenced this pull request Sep 9, 2019
5 of 13 tasks complete
@walterra
Copy link
Contributor

left a comment

ML changes LGTM.

@thompsongl

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

Re-ping @elastic/apm-ui and @elastic/kibana-security

Other owned coder pings were for snapshot tests only

</EuiContextMenuItem>
) : null
);
.map(({ icon, key, child }) => (

This comment has been minimized.

Copy link
@sqren

sqren Sep 10, 2019

Member

This change looks good but not really related to the EUI update, is it?
Do leave it in though 👍

This comment has been minimized.

Copy link
@thompsongl

thompsongl Sep 10, 2019

Author Contributor

EuiContextMenuPanel was converted to TS and its items prop no longer accepts null entries (it never really did, but it wasn't typed). Removing the unneeded conditional returns a null-less array, which passes the type check.

@sqren
sqren approved these changes Sep 10, 2019
Copy link
Member

left a comment

LGTM

@snide
snide approved these changes Sep 11, 2019
@azasypkin
Copy link
Member

left a comment

Changes in Security and Spaces plugins LGTM.

@thompsongl thompsongl merged commit bec1fa6 into elastic:master Sep 11, 2019

55 checks passed

API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Firefox smoke test node scripts/functional_tests --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-firefoxSmoke/node/linux-immutable/install/kibana --include-tag smoke --config test/functional/config.firefox.js
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Kibana visual regression tests yarn run percy exec node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-visualRegression/node/linux-immutable/install/kibana --config test/visual_regression/config.ts
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir ./build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup1/node/linux-immutable/install/kibana --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup10/node/linux-immutable/install/kibana --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup2/node/linux-immutable/install/kibana --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup3/node/linux-immutable/install/kibana --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup4/node/linux-immutable/install/kibana --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup5/node/linux-immutable/install/kibana --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup6/node/linux-immutable/install/kibana --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup7/node/linux-immutable/install/kibana --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup8/node/linux-immutable/install/kibana --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-ciGroup9/node/linux-immutable/install/kibana --include-tag ciGroup9
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Mocha yarn test
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack firefox smoke test node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-firefoxSmoke/node/linux-immutable/install/kibana --include-tag smoke --config test/functional/config.firefox.js
Details
X-Pack visual regression tests yarn run percy exec node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/x-pack-visualRegression/node/linux-immutable/install/kibana --config test/visual_regression/config.js
Details
elasticsearch-ci/docs Build finished.
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
percy/kibana Visual review automatically approved, no visual changes found.
Details
prbot:outdated run `node scripts/update_prs 45052` to update
prbot:release note labels
prbot:release version labels
sasslint node scripts/sasslint
Details
thompsongl added a commit to thompsongl/kibana that referenced this pull request Sep 11, 2019
Upgrade EUI to 13.8.1 (elastic#45052)
* eui to 13.8.0

* euibutton ts updates

* euicontextmenupanel ts updates

* misc ts updates

* src snapshot updates

* x-pack snapshot updates

* 13.8.1
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 11, 2019
Merge branch 'master' of github.com:elastic/kibana into chore/console…
…-to-np-ready

* 'master' of github.com:elastic/kibana:
  Upgrade EUI to 13.8.1 (elastic#45052)
  [ML] Add multi metric job wizard test (elastic#45279)
  [SIEM] Inject/apply KQL changed in refresh button (elastic#45065)
  [Graph] Type persistence (elastic#44985)
  Functional tests: convert more test/services to TS (elastic#45176)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 11, 2019
Merge branch 'master' of github.com:elastic/kibana into lock_monaco_e…
…ditor

* 'master' of github.com:elastic/kibana: (76 commits)
  Upgrade EUI to 13.8.1 (elastic#45052)
  [ML] Add multi metric job wizard test (elastic#45279)
  [SIEM] Inject/apply KQL changed in refresh button (elastic#45065)
  [Graph] Type persistence (elastic#44985)
  Functional tests: convert more test/services to TS (elastic#45176)
  [ML] Fixes display of matching modules in index data visualizer (elastic#45261)
  [Console] Update indentation behaviour (elastic#45249)
  Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259)
  [Region Map] Fix loading default vector map and base layer setting (elastic#43858)
  [ML] Fixing empty time range when cloning jobs (elastic#45286)
  [ML] Fixing wizard validation delay (elastic#45265)
  [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268)
  [Console] SQL template with triple quote in completion (elastic#45248)
  [ML] Data Frames: Cards as links (elastic#45254)
  fix(code/frontend): should show updating instead of cloning when updating (elastic#45238)
  fix(code/frontend): fix document search result from (elastic#45236)
  disable another flaky suite (elastic#45323) (elastic#45330)
  disable flaky suite (elastic#45105)
  skip flaky suite (elastic#43069)
  skip flaky suite (elastic#45089)
  ...
thompsongl added a commit that referenced this pull request Sep 11, 2019
[7.x] Upgrade EUI to 13.8.1 (#45052) (#45398)
* Upgrade EUI to 13.8.1 (#45052)

* eui to 13.8.0

* euibutton ts updates

* euicontextmenupanel ts updates

* misc ts updates

* src snapshot updates

* x-pack snapshot updates

* 13.8.1

* snapshot update (poor merge conflict resolution)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.