[APM] Always show transaction breakdown #46684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgieselaar Any reason why we wouldn't make the empty state the same whether collapsed or expanded? If we can't show any KPI values, we also can't show a chart - so I think we should stick to a minimal panel with an empty message similar to the one in the current version (which I understand is very broad in terms of its copy). |
💚 Build Succeeded |
sorenlouv
approved these changes
Sep 26, 2019
|
@formgeist my main concern was page jumping and consistency with how the other charts display their empty state. |
dgieselaar
force-pushed
the
always-show-breakdown
branch
from
2a07d1b
to
61050f6
Compare
|
Added an empty state message to the collapsed state of the component after discussing with @formgeist. |
💚 Build Succeeded |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Sep 27, 2019
* [APM] Always show transaction breakdown Closes elastic#43527. * Show empty message for collapsed state
dgieselaar
added a commit
that referenced
this pull request
Sep 30, 2019
sorenlouv
added
the
apm:test-plan-done
|
Test plan: verified ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43527.
We might want to look at the empty state for when the component is collapsed. Any suggestions @formgeist?
Badge:
=>
Empty state:
=>
expanded:
collapsed: