Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] JVM List view & JVM metrics page #46779

Merged
merged 9 commits into from Oct 3, 2019

Conversation

@dgieselaar
Copy link
Contributor

commented Sep 27, 2019

Closes #43765.

Before:
image

After:

JVM Overview page:
image

JVM Detail metrics page:
image

  • change Metrics tab for a JVMs tab

  • the local filters on this page should be the same as for the other tabs

  • add a table listing all JVMs and system.process.cpu.total.norm.pct (avg), jvm.memory.heap.used (avg), jvm.memory.non_heap.used (avg), jvm.thread.count (max)

  • the table should be sortable

  • the values in the table should be reference the timeframe selected in the datepicker

  • link these JVMs to a new JVM specific page

  • show JVM specific metrics on JVM page (the same charts as currently visible in the Metrics tab)

  • add a Meta data panel for container ID info

  • use service.node.name when elastic/apm#141 lands in apm-server/apm-agent-java.

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

@dgieselaar dgieselaar force-pushed the dgieselaar:jvm-list branch from 13896c5 to 26d3118 Sep 27, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

@dgieselaar dgieselaar referenced this pull request Sep 30, 2019
0 of 8 tasks complete
const getJvms = async ({
setup,
serviceName,
sortField,

This comment has been minimized.

Copy link
@sqren

sqren Sep 30, 2019

Member
Suggested change
sortField,
sortField = '_key',
@dgieselaar dgieselaar force-pushed the dgieselaar:jvm-list branch from 26d3118 to 32a69eb Oct 1, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

@dgieselaar dgieselaar force-pushed the dgieselaar:jvm-list branch from 32a69eb to 13b8497 Oct 1, 2019
@dgieselaar dgieselaar requested a review from formgeist Oct 1, 2019
@dgieselaar dgieselaar marked this pull request as ready for review Oct 1, 2019
@dgieselaar dgieselaar requested a review from elastic/apm-ui as a code owner Oct 1, 2019
@dgieselaar

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

@sqren we previously discussed sticking to using JVM-specific names, but I decided to use serviceNode to conform to what the agents and server are using. There should be no reference to JVMs other than display labels. Let me know how you feel about that.

Copy link
Contributor

left a comment

LGTM (minor truncate tooltip comment)

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

@dgieselaar dgieselaar force-pushed the dgieselaar:jvm-list branch from 31aa8f2 to 7d2ae43 Oct 1, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

@dgieselaar dgieselaar force-pushed the dgieselaar:jvm-list branch from 7d2ae43 to d187e60 Oct 2, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

@sqren
sqren approved these changes Oct 2, 2019
Copy link
Member

left a comment

lgtm 👍

@dgieselaar dgieselaar force-pushed the dgieselaar:jvm-list branch 2 times, most recently from 05f0d5d to e7ff19d Oct 3, 2019
dgieselaar added 8 commits Sep 27, 2019
Closes #43765.
@dgieselaar dgieselaar force-pushed the dgieselaar:jvm-list branch from e7ff19d to ae79c44 Oct 3, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

@dgieselaar dgieselaar merged commit 1592600 into elastic:master Oct 3, 2019
52 checks passed
52 checks passed
API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Firefox smoke test node scripts/functional_tests --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64 --include-tag smoke --config test/functional/config.firefox.js
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-1
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-1
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-1 --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-10 --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-2 --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-3 --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-4 --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-5 --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-6 --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-7 --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-8 --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-9 --include-tag ciGroup9
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Mocha yarn test
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack firefox smoke test node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-11 --include-tag smoke --config test/functional/config.firefox.js
Details
elasticsearch-ci/docs Build finished.
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
prbot:outdated
prbot:release note labels
prbot:release version labels
sasslint node scripts/sasslint
Details
@dgieselaar dgieselaar deleted the dgieselaar:jvm-list branch Oct 3, 2019
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Oct 3, 2019
* [APM] JVM List view & JVM metrics page

Closes elastic#43765.

* Add service node metadata

* Use service node terminology

* Use asPercent for CPU

* Tooltip for truncated elements

* Add processor.event filters

* Use service.node.name

* Sort client-side only

* Add processor.event filter to service nodes projection
dgieselaar added a commit that referenced this pull request Oct 4, 2019
* [APM] JVM List view & JVM metrics page

Closes #43765.

* Add service node metadata

* Use service node terminology

* Use asPercent for CPU

* Tooltip for truncated elements

* Add processor.event filters

* Use service.node.name

* Sort client-side only

* Add processor.event filter to service nodes projection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.