Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show toast after a new watcher is created #47197

Closed
wants to merge 1 commit into from

Conversation

@cauemarcondes
Copy link
Contributor

commented Oct 3, 2019

closes #46454

Pass the Kibana context to KibanaLink in case it cannot get it from the KibanaCore hook.

@cauemarcondes cauemarcondes requested a review from elastic/apm-ui as a code owner Oct 3, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

@@ -260,7 +260,8 @@ export class WatcherFlyout extends Component<
}
)}{' '}
<KibanaLink
path={`/management/elasticsearch/watcher/watches/watch/${id}`}
path={`/management/elasticsearch/watcher/watches/watch/${id}/status`}

This comment has been minimized.

Copy link
@sqren

sqren Oct 3, 2019

Member

Did the endpoint change?

This comment has been minimized.

Copy link
@cauemarcondes

cauemarcondes Oct 3, 2019

Author Contributor

@sqren, I changed it because the old link was going to the Watcher List Page instead of opening the watcher which has just been created. Unless that is the correct behavior?

This comment has been minimized.

Copy link
@sqren

sqren Oct 3, 2019

Member

This looks good. Thanks for catching this 👍

@sqren
sqren approved these changes Oct 3, 2019
@sqren

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Btw. can you check if we have the same problem with machine learning (ML) integration and in that case fix it in this PR too?

@cauemarcondes

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

retest

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.