Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM]Show `span.http.response.status_code` and `span.http` object in Span details flyout #47322

Merged
merged 11 commits into from Oct 10, 2019

Conversation

@cauemarcondes
Copy link
Contributor

commented Oct 4, 2019

closes #31099 #35219

Http Status code badge and Metadata tab added:
Screenshot 2019-10-08 at 10 19 49

Transacting and Error ids were added on each flyout.

Screenshot 2019-10-08 at 10 21 01

Screenshot 2019-10-08 at 10 22 03

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

@cauemarcondes cauemarcondes marked this pull request as ready for review Oct 4, 2019
@cauemarcondes cauemarcondes requested a review from elastic/apm-ui as a code owner Oct 4, 2019
@cauemarcondes cauemarcondes changed the title Extracting HttpStatusBadge component, in order to be used on SpanFlyout [APM]Show `span.http.response.status_code` and `span.http` object in Span details flyout Oct 4, 2019
@smith
smith approved these changes Oct 4, 2019
Copy link
Member

left a comment

I have a few suggestions but nothing that would block merging this. Nice work!

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

Copy link
Member

left a comment

Great enhancements 👍 I added a few comments arounds which sections to display.

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

@formgeist

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

@cauemarcondes Would it be possible to move the HTTP status badge in before the span type, subtype and action badges?
66218505-9c809c00-e6c9-11e9-90b0-35def0811d4c

@cauemarcondes

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

@cauemarcondes Would it be possible to move the HTTP status badge in before the span type, subtype and action badges?
66218505-9c809c00-e6c9-11e9-90b0-35def0811d4c

@formgeist Sure I can

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

@cauemarcondes cauemarcondes requested a review from sqren Oct 8, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

@cauemarcondes cauemarcondes requested a review from sqren Oct 8, 2019
@cauemarcondes cauemarcondes force-pushed the cauemarcondes:apm-59791 branch from 1c4ed15 to a0adbf9 Oct 8, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@sqren
sqren approved these changes Oct 9, 2019
Copy link
Member

left a comment

Just a few nits. Looks great!

@@ -68,6 +31,10 @@ const Span = styled('span')`
`;

export function HttpInfoSummaryItem({ status, method, url }: HttpInfoProps) {
if (!url) {
return null;
}

This comment has been minimized.

Copy link
@sqren

sqren Oct 9, 2019

Member

This is no longer needed, since url is required, right?

This comment has been minimized.

Copy link
@cauemarcondes

cauemarcondes Oct 10, 2019

Author Contributor

I added to return null also if the url is ""

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2019

@cauemarcondes cauemarcondes merged commit e459f40 into elastic:master Oct 10, 2019
52 checks passed
52 checks passed
API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Firefox smoke test node scripts/functional_tests --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64 --include-tag smoke --config test/functional/config.firefox.js
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-1
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-1
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-1 --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-5 --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-2 --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-3 --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-4 --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-5 --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-1 --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-2 --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-3 --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-4 --include-tag ciGroup9
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Mocha yarn test
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack firefox smoke test node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-6 --include-tag smoke --config test/functional/config.firefox.js
Details
elasticsearch-ci/docs Build finished.
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
prbot:outdated
prbot:release note labels
prbot:release version labels
sasslint node scripts/sasslint
Details
@cauemarcondes cauemarcondes deleted the cauemarcondes:apm-59791 branch Oct 10, 2019
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Oct 10, 2019
…Span details flyout (elastic#47322)

* Extracting HttpStatusBadge component, in order to be used on SpanFlyout

* Changing tab labels to metadata

* Changing tab labels to metadata

* Refactoring section labels

* Refactoring section labels

* Refactoring section labels

* Refactoring http info component

* adding new translation

* Refactoring section

* fixing type check on test

* Using lodash pick to get the correct properties
cauemarcondes added a commit that referenced this pull request Oct 10, 2019
…Span details flyout (#47322) (#47793)

* Extracting HttpStatusBadge component, in order to be used on SpanFlyout

* Changing tab labels to metadata

* Changing tab labels to metadata

* Refactoring section labels

* Refactoring section labels

* Refactoring section labels

* Refactoring http info component

* adding new translation

* Refactoring section

* fixing type check on test

* Using lodash pick to get the correct properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.