Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency execa to v2 #47498

Open
wants to merge 9 commits into
base: master
from

Conversation

@renovate
Copy link
Contributor

commented Oct 7, 2019

This PR contains the following updates:

Package Type Update Change
execa devDependencies major ^1.0.0 -> ^2.0.5
execa dependencies major ^1.0.0 -> ^2.0.5

Release Notes

sindresorhus/execa

v2.0.5

Compare Source

Bug fixes

v2.0.4

Compare Source

Bug fixes

  • Fix errors being thrown when detached: true or cleanup: false is used (#​360) 211febe

v2.0.3

Compare Source

Bug fixes

  • Add missing TypeScript definition for all (#​345)

Documentation

  • Add tip on how to execute the current package's binary (#​339, #​340)

v2.0.2

Compare Source

Bug fixes

v2.0.1

Compare Source

Bug fixes

  • Correctly set the engines.node field in package.json. Supported Node versions are either ^8.12.0 or >=9.7.0 (#​319, #​323)

Documentation

v2.0.0

Compare Source

Thanks to @​GMartigny, @​BendingBender, @​tomsotte, @​ammarbinfaisal, @​zokker13, @​stroncium, @​satyarohith, @​bradfordlemley, @​coreyfarrell, @​brandon93s, @​dtinth, @​papb for the great features and bug fixes they've contributed!

Please check the Medium article about this release!

Breaking changes

Features

Bug fixes

Documentation

Design

Tests

Maintainers


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot requested review from elastic/kibana-operations as code owners Oct 7, 2019
@renovate

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

Copy link
Member

left a comment

LGTM

@spalger

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

@elasticmachine merge upstream

};

const runApiDocumenter = async (folder: string) => {
await execa.shell(
`api-documenter markdown -i ./build/${folder} -o ./docs/development/core/${folder}`
await execa(

This comment has been minimized.

Copy link
@tylersmalley

tylersmalley Oct 7, 2019

Member

I see you dropped shell from these two commands - just want to confirm that was intentional.

This comment has been minimized.

Copy link
@spalger

spalger Oct 7, 2019

Member

Best I could tell these only used shell so they didn't need to specify the arguments as independent values, but doing so makes for better escaping which is a good habit I think and especially important here.

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@spalger

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

I'm going to wait until sindresorhus/execa#353 is released because kbn-es is broken without this convenience, but if we need to upgrade we could go earlier. We hopefully will be getting a v3 soon sindresorhus/execa#351 (comment)

@renovate

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2019

Autoclosing Skipped

This PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.