Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Documentation and alignment for impact column #47602

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@smith
Copy link
Member

commented Oct 8, 2019

In the traces and transactions tables, left align the impact column heading and add a tooltip explaining what it means.

Fixes #44313
Fixes #28559

image

@smith smith requested review from felixbarny and bmorelli25 Oct 8, 2019
@smith smith requested a review from elastic/apm-ui as a code owner Oct 8, 2019
Copy link
Member

left a comment

Oh, nice! Since this is a tool tip, I don't think we need to explicitly say "Impact is..". What about something like this:

The most used and slowest endpoints in your service. Calculated by multiplying the relative average duration with the number of transactions per minute.

@sqren
sqren approved these changes Oct 8, 2019
Copy link
Member

left a comment

Nice enhancement!

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

Copy link
Contributor

left a comment

Looks great @smith 👍

name: (
<EuiToolTip
content={i18n.translate(
'xpack.apm.tracesTable.impactColumnDescription',
{
defaultMessage:
"The most used and slowest endpoints in your service. It's calculated by taking the relative average duration times the number of transactions per minute."
}
)}
>
<>
{i18n.translate('xpack.apm.tracesTable.impactColumnLabel', {
defaultMessage: 'Impact'
})}
</>
</EuiToolTip>
),
Comment for lines 88  – 110

This comment has been minimized.

Copy link
@formgeist

formgeist Oct 8, 2019

Contributor

EUI has an example in their tables docs where they add a small icon to indicate that there's some more information on the table name.

Screenshot 2019-10-08 at 20 20 51

name: (
          <EuiToolTip content="Their mascot is the Octokitty">
            <span>
              Github{' '}
              <EuiIcon
                size="s"
                color="subdued"
                type="questionInCircle"
                className="eui-alignTop"
              />
            </span>
          </EuiToolTip>
        )

Would we be able to add this in as a small visual enhancement too?

This comment has been minimized.

Copy link
@smith

smith Oct 8, 2019

Author Member

Added in 684e12d.

smith added 3 commits Oct 8, 2019
In the traces and transactions tables, left align the impact column heading and add a tooltip explaining what it means.

Fixes #44313
Fixes #28559
@smith smith force-pushed the smith:nls/44313/impact branch from c21975f to 684e12d Oct 8, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

@smith smith merged commit c6c397f into elastic:master Oct 8, 2019
52 checks passed
52 checks passed
API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Firefox smoke test node scripts/functional_tests --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64 --include-tag smoke --config test/functional/config.firefox.js
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-1
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-1
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-1 --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-5 --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-2 --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-3 --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-4 --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-5 --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-1 --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-2 --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-3 --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-4 --include-tag ciGroup9
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Mocha yarn test
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack firefox smoke test node scripts/functional_tests --debug --bail --kibana-install-dir /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/install/kibana-6 --include-tag smoke --config test/functional/config.firefox.js
Details
elasticsearch-ci/docs Build finished.
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
prbot:outdated
prbot:release note labels
prbot:release version labels
sasslint node scripts/sasslint
Details
@smith smith deleted the smith:nls/44313/impact branch Oct 8, 2019
smith added a commit to smith/kibana that referenced this pull request Oct 10, 2019
In the traces and transactions tables, left align the impact column heading and add a tooltip explaining what it means.

Fixes elastic#44313
Fixes elastic#28559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.