Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Top Countries network page tab change; fix column heading bug #48526

Merged
merged 3 commits into from Oct 17, 2019

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 17, 2019

Summary

  • Moves the Top Countries table to be beneath the IP Tables on the Network Page
  • Fixes bug that shows the same flow heading on the opposite column in the Top Countries Table
  • Changes the IPs tab label to Flows
  • Changes the Top Countries table headings to no longer include the word "Top"

Stacked tables & translation changes:
Screen Shot 2019-10-17 at 8 24 24 AM

Bug Before:
Screen Shot 2019-10-17 at 7 18 15 AM

No Bug After:
Screen Shot 2019-10-17 at 7 17 09 AM

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants