Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Update Error occurrences graph tooltip to display start and end for bucket period #49638

Merged
merged 27 commits into from Nov 15, 2019

Conversation

@cauemarcondes
Copy link
Contributor

cauemarcondes commented Oct 29, 2019

closes #18182

Screenshot 2019-10-29 at 15 25 28

@cauemarcondes cauemarcondes requested a review from elastic/apm-ui as a code owner Oct 29, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 29, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 29, 2019

@cauemarcondes cauemarcondes requested a review from sqren Oct 29, 2019
@cauemarcondes cauemarcondes force-pushed the cauemarcondes:apm-31509 branch from ff67b9e to 05ffb28 Oct 30, 2019
@cauemarcondes cauemarcondes requested a review from sqren Oct 30, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 30, 2019

@cauemarcondes

This comment has been minimized.

Copy link
Contributor Author

cauemarcondes commented Oct 30, 2019

jenkins, retest this please

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 30, 2019

@cauemarcondes cauemarcondes requested a review from sqren Oct 31, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 31, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Oct 31, 2019

? getCustomTimezoneFormat(utcOffsetHours)
: DEFAULT_TIMEZONE_FORMAT;

return momentTime.format(`(UTC${utcOffsetFormatted})`);

This comment has been minimized.

Copy link
@sqren

sqren Nov 1, 2019

Member

Side note: I'm starting to wonder whether it even makes sense to have a custom timezone format. I did it because I thought the standard was too long (UTC+02:00 vs UTC+2) but not sure it's a good idea to fiddle with these things. Either way, let's make a mental note and remove it if it causes confusion/problems for end users.

This comment has been minimized.

Copy link
@sqren

sqren Nov 1, 2019

Member

I guess we are not the only ones to use the shorthand:
image

(from www.time.is)

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Nov 1, 2019

cauemarcondes added 22 commits Oct 31, 2019
@cauemarcondes cauemarcondes force-pushed the cauemarcondes:apm-31509 branch from 993f4b4 to 565c366 Nov 15, 2019
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Nov 15, 2019

@cauemarcondes cauemarcondes merged commit c982b8f into elastic:master Nov 15, 2019
57 checks passed
57 checks passed
API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits in pull request signed
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Firefox smoke test node scripts/functional_tests --bail --debug --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64 --include-tag smoke --config test/functional/config.firefox.js
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.js --bail --debug --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-1
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Kibana accessibility tests node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64 --config test/accessibility/config.ts
Details
Kibana visual regression tests yarn run percy exec -t 500 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64 --config test/visual_regression/config.ts
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-1
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-1 --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-10 --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-2 --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-3 --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-4 --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-5 --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-6 --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-7 --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-8 --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-9 --include-tag ciGroup9
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Mocha yarn test
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack accessibility tests node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana --config test/accessibility/config.ts
Details
X-Pack firefox smoke test node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-11 --include-tag smoke --config test/functional/config.firefox.js
Details
X-Pack visual regression tests yarn run percy exec -t 500 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-13 --config test/visual_regression/config.js
Details
elasticsearch-ci/docs Build finished.
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
percy/kibana Visual review automatically approved, no visual changes found.
Details
prbot:outdated
prbot:release note labels
prbot:release version labels
sasslint node scripts/sasslint
Details
@cauemarcondes cauemarcondes deleted the cauemarcondes:apm-31509 branch Nov 15, 2019
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Nov 15, 2019
… for bucket period (elastic#49638)

* Adding end time inside error tooltip

* changing end time precision

* refactoring

* refactoring

* pr comments refactoring

* pr comments refactoring

* pr comments refactoring

* pr comments refactoring

* renaming some functions to make it more clear

* Refactoring date difference range

* refactoring transformers file

* refactoring date time formatters

* refactoring formatters into a new folder

* refactoring getDurationUnit

* refactoring duration formatter

* fixing unit test

* refactoring unit test

* Adding timezone to tests

* fixing translation issue

* fixing translation issue

* improving code

* exporting toMicroseconds

* removing unused import

* refactoring duration

* refactoring duration

* fixing unit test

* fixing unit test
cauemarcondes added a commit that referenced this pull request Nov 15, 2019
… for bucket period (#49638) (#50769)

* Adding end time inside error tooltip

* changing end time precision

* refactoring

* refactoring

* pr comments refactoring

* pr comments refactoring

* pr comments refactoring

* pr comments refactoring

* renaming some functions to make it more clear

* Refactoring date difference range

* refactoring transformers file

* refactoring date time formatters

* refactoring formatters into a new folder

* refactoring getDurationUnit

* refactoring duration formatter

* fixing unit test

* refactoring unit test

* Adding timezone to tests

* fixing translation issue

* fixing translation issue

* improving code

* exporting toMicroseconds

* removing unused import

* refactoring duration

* refactoring duration

* fixing unit test

* fixing unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.