New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force worker-json to 0644 mode #4969

merged 1 commit into from Sep 17, 2015


None yet
2 participants

w33ble commented Sep 17, 2015

The file permissions on worker-json.js from the Ace editor in the linux builds are wrong, since they were wrong on the machine used to create the build. This was pointed out in #4913

$ tar tzvf kibana-4.1.2-linux-x64.tar.gz | less
-rw-------  0 spalger staff   72696 Sep  8 13:12 kibana-4.1.2-linux-x64/src/public/worker-json.js
$ tar tzvf kibana-4.1.2-linux-x86.tar.gz | less
-rw-------  0 spalger staff   72696 Sep  8 13:12 kibana-4.1.2-linux-x86/src/public/worker-json.js

This change forces the mode for that file to 0644 when the build copies it into the dist


This comment has been minimized.

Show comment
Hide comment

spalger Sep 17, 2015


LGTM, once tests pass will merge


spalger commented Sep 17, 2015

LGTM, once tests pass will merge

spalger added a commit that referenced this pull request Sep 17, 2015

Merge pull request #4969 from w33ble/ace-worker-permissions
force worker-json to 0644 mode

@spalger spalger merged commit 76e5789 into elastic:4.1 Sep 17, 2015

3 checks passed

CLA Commit author has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
default Merged build finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment