New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbind popup events when moving the map #4999

Merged
merged 3 commits into from Sep 24, 2015

Conversation

Projects
None yet
2 participants
@w33ble
Member

w33ble commented Sep 22, 2015

Fixes #4898

It seems like the popup events aren't properly being torn down then layers are removed, so the mouseout event is fired on the layer when it's no longer a part of the map object. This causes Leaflet to fatal.

  • Explicitly unbind events on the popup objects
    • Layers were already removed and recreated each time
  • Little bit of code cleanup

w33ble added some commits Sep 22, 2015

unify tooltip hiding, explicity unbind popup events
seems like leaflet doesn't propertly clean up events bound to layers being removed
@spalger

This comment has been minimized.

Show comment
Hide comment
@spalger

spalger Sep 24, 2015

Member

LGTM

Member

spalger commented Sep 24, 2015

LGTM

spalger added a commit that referenced this pull request Sep 24, 2015

Merge pull request #4999 from w33ble/map-event-fatal
Unbind popup events when moving the map

@spalger spalger merged commit 39fd5a2 into elastic:4.1 Sep 24, 2015

3 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment