New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date formatter] Display hyphen on null or undefined dates #5090

Merged
merged 1 commit into from Oct 9, 2015

Conversation

Projects
None yet
2 participants
@jbudz
Contributor

jbudz commented Oct 9, 2015

Currently in master and 4.2, null dates display an empty string while strings show a -.

Some test data if it's useful:

curl -XPUT 'http://localhost:9200/foo/bar/1' -d '
{
    "string1": "hello",
    "string2": null,
    "date1": "2011-12-15",
    "date2": null
}'

Closes #4891

@BigFunger

This comment has been minimized.

Show comment
Hide comment
@BigFunger

BigFunger Oct 9, 2015

Contributor

LGTM

Contributor

BigFunger commented Oct 9, 2015

LGTM

@BigFunger BigFunger assigned jbudz and unassigned BigFunger Oct 9, 2015

@jbudz jbudz added v4.1.3 and removed v4.1.3 labels Oct 9, 2015

jbudz added a commit that referenced this pull request Oct 9, 2015

Merge pull request #5090 from jbudz/issues/4891
[date formatter] Display hyphen on null or undefined dates

@jbudz jbudz merged commit 209951b into elastic:master Oct 9, 2015

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
CLA Commit author is a member of Elasticsearch
Details
default Merged build finished.
Details

jbudz added a commit that referenced this pull request Oct 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment