Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pinned ES snapshot #53645

Closed
wants to merge 9 commits into from
Closed

Conversation

@jbudz
Copy link
Contributor

jbudz commented Dec 19, 2019

Elasticsearch was pinned to an older version due to a migrations
failure. Root cause was determined to be upstream and tracked at
elastic/elasticsearch#50248. Now that a fix is merged we can see where
the most recent snapshot leaves us.

jbudz added 3 commits Dec 19, 2019
Elasticsearch was pinned to an older version due to a migrations
failure.  Root cause was determined to be upstream and tracked at
elastic/elasticsearch#50248.  Now that a fix is merged we can see where
the most recent snapshot leaves us.
Until new artifacts are built we need to build from source to test the
mappings fix.  This is for testing the most recent fixes and should be reverted before merging.
@jbudz jbudz changed the title Issues/pinned es snapshot Revert pinned ES snapshot Dec 19, 2019
@cjcenizal cjcenizal mentioned this pull request Dec 19, 2019
0 of 2 tasks complete
@jbudz

This comment has been minimized.

Copy link
Contributor Author

jbudz commented Dec 20, 2019

retest

@jbudz

This comment has been minimized.

Copy link
Contributor Author

jbudz commented Dec 20, 2019

elastic/elasticsearch#49166 is next - short term we need to set fielddata to true.

jbudz added 2 commits Dec 20, 2019
In 8.0 field data is defaulted to false in Elasticsearch.  We make use
if this in several areas.  The setting change is to reduce
memory pressure.  The Kibana index typically isn't very large so this is
not expected to have a large impact.
@jbudz

This comment has been minimized.

Copy link
Contributor Author

jbudz commented Dec 20, 2019

Migrations are running on hash changes of mappings it looks like..need to push settings changes

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Dec 20, 2019

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Jan 8, 2020

@elasticmachine merge upstream

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Jan 8, 2020

merge conflict between base and head

@kibanamachine

This comment has been minimized.

Copy link

kibanamachine commented Jan 9, 2020

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@@ -51,6 +52,9 @@ export async function fetchInfo(callCluster: CallCluster, index: string): Promis
aliases: {},
exists: false,
indexName: index,
settings: {
'indices.id_field_data.enabled': true,

This comment has been minimized.

Copy link
@tylersmalley

tylersmalley Jan 9, 2020

Member

I am not sure what this would do here. In addition, this is a cluster-level setting, so this won't work. I believe the solution here is to remove any sort/aggregating we have on _id

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Jan 9, 2020

I have highlighted the path forward here: #52517 (comment). Since we're automating the snapshots, we no longer need this PR to unpin the snapshot once the sorting on _id has been removed.

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Jan 21, 2020

This can be closed.

@jbudz jbudz closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.