Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mappings editor] Description text for shape, geo-point types #53943

Merged
merged 3 commits into from
Jan 6, 2020
Merged

[Mappings editor] Description text for shape, geo-point types #53943

merged 3 commits into from
Jan 6, 2020

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Jan 3, 2020 •
edited

This PR adds description text for the shape data type and geo-point.

Fixes #53733

Shape text
Screen Shot 2020-01-03 at 2 05 10 PM

Geo-point text
Screen Shot 2020-01-03 at 2 05 20 PM

@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Mappings Editor Index mappings editor UI labels Jan 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

gchaps
gchaps reviewed Jan 3, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggestions:

Shape fields enable searching of complex shapes, such as rectangles and polygons.

Geo-point fields accept latitude and longitude pairs. Use to search within a bounding box, aggregate documents geographically, and sort documents by distance.

@alisonelizabeth
Copy link
Contributor Author

Thanks for the review, @gchaps! I updated the PR with your suggested changes.

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cjcenizal
cjcenizal approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alisonelizabeth alisonelizabeth merged commit f6f562a into elastic:feature/mappings-editor Jan 6, 2020
@alisonelizabeth alisonelizabeth deleted the mappings-editor/geo-shape-help-text branch January 6, 2020 23:39
@gchaps
Copy link
Contributor

gchaps commented Jan 7, 2020

Just talked with @cjcenizal, and I agree that the text for geo-point fields sounds a little terse. How about this:

Geo-point fields accept latitude and longitude pairs. Use this data type to search within a bounding box, aggregate documents geographically, and sort documents by distance.

@alisonelizabeth alisonelizabeth mentioned this pull request Jan 7, 2020
Merged
@alisonelizabeth
Copy link
Contributor Author

alisonelizabeth commented Jan 7, 2020 •
edited

@gchaps Since this PR has already been merged, I updated the text via #54113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps left review comments

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
Feature:Mappings Editor Index mappings editor UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alisonelizabeth @elasticmachine @kibanamachine @gchaps @cjcenizal