-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mappings editor] Description text for shape, geo-point types #53943
[Mappings editor] Description text for shape, geo-point types #53943
Conversation
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggestions:
Shape fields enable searching of complex shapes, such as rectangles and polygons.
Geo-point fields accept latitude and longitude pairs. Use to search within a bounding box, aggregate documents geographically, and sort documents by distance.
Thanks for the review, @gchaps! I updated the PR with your suggested changes. |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just talked with @cjcenizal, and I agree that the text for geo-point fields sounds a little terse. How about this: Geo-point fields accept latitude and longitude pairs. Use this data type to search within a bounding box, aggregate documents geographically, and sort documents by distance. |
This PR adds description text for the shape data type and geo-point.
Fixes #53733
Shape text
![Screen Shot 2020-01-03 at 2 05 10 PM](https://user-images.githubusercontent.com/5226211/71743261-1d1e7800-2e32-11ea-8de3-33a828d00e76.png)
Geo-point text
![Screen Shot 2020-01-03 at 2 05 20 PM](https://user-images.githubusercontent.com/5226211/71743262-1d1e7800-2e32-11ea-9f79-53da61f36dd5.png)