New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 4.3: Fix IndexPattern leaking #5469

Closed
wants to merge 14 commits into
base: 4.3
from

Conversation

Projects
None yet
3 participants
@spalger
Member

spalger commented Nov 23, 2015

Backport #5460, #5455 and #5456 to 4.3

spalger added some commits Nov 19, 2015

[courier/requestQueue] fix get(), added getStartable()
get() implies that it will get all pending requests that match a strategy, but it is actually filtering by wether a require is startable. Added getStartable() to accomplish that task and get() now returns all requests that match a strategy.
[promise/Constructor] remove non-standard `defer` arg
At some point I added a `defer` arg to the Promise constructor in our promises library. This arg is not a part of ECMA promises or bluebird promises, so I'm removing it to keep compatibility.
[indexPattern] don't cache indexPatterns without ids
In a few places we are creating index patterners that don't have ids. A primary location is in indexPattern creation, where we will end up setting the id. If we cache the indexPattern before it has an id the cache gets out of sync, so we need to not cache indexPatterns without ids.

@spalger spalger changed the title from Fix IndexPattern leaking for 4.3 to Backport to 4.3: Fix IndexPattern leaking Nov 23, 2015

@epixa

This comment has been minimized.

Member

epixa commented Dec 9, 2015

Closing this in favor of a direct backport of #5460

@epixa epixa closed this Dec 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment