Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 💍 re-enable Dashboard sample data functional tests #54717

Merged
merged 1 commit into from Jan 14, 2020
Merged

test: 💍 re-enable Dashboard sample data functional tests #54717

merged 1 commit into from Jan 14, 2020

Conversation

streamich
Copy link
Contributor

Closes: #40670

@streamich streamich added release_note:skip Skip the PR/issue when compiling release notes review Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:Operations Team label for Operations Team v7.6.0 v8.0.0 labels Jan 14, 2020
@streamich streamich requested a review from kertal January 14, 2020 13:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@streamich streamich requested review from nreese, spalger, kertal and ppisljar and removed request for kertal January 14, 2020 13:07
@streamich streamich mentioned this pull request Jan 14, 2020
Closed
@streamich streamich removed the request for review from kertal January 14, 2020 13:22
ppisljar
ppisljar approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit b7f3782 into elastic:master Jan 14, 2020
@streamich streamich mentioned this pull request Jan 14, 2020
Merged
streamich added a commit that referenced this pull request Jan 14, 2020
@streamich
test: 💍 re-enable Dashboard sample data functional tests (#54717) (#5…
1e87504 
…4732)

Closes: #40670
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@streamich @jkelastic
test: 💍 re-enable Dashboard sample data functional tests (elastic#54717)
7817c99 
Closes: elastic#40670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@nreese nreese Awaiting requested review from nreese

@spalger spalger Awaiting requested review from spalger

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Operations Team label for Operations Team Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@streamich @elasticmachine @kibanamachine @ppisljar