Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Divide "Actions menu" into sections to improve readability #56623

Merged
merged 16 commits into from Feb 17, 2020

Conversation

@cauemarcondes
Copy link
Contributor

cauemarcondes commented Feb 3, 2020

closes #53588

Screenshot 2020-02-03 at 15 11 33

Screenshot 2020-02-03 at 15 20 58

Screenshot 2020-02-03 at 15 21 15

@cauemarcondes cauemarcondes requested a review from elastic/apm-ui as a code owner Feb 3, 2020
@cauemarcondes cauemarcondes requested review from dgieselaar and ogupte Feb 5, 2020
@smith smith self-requested a review Feb 5, 2020
@smith
smith approved these changes Feb 5, 2020
Copy link
Member

smith left a comment

tenor-196430137

@cauemarcondes cauemarcondes force-pushed the cauemarcondes:actions-menu branch from d5fbaac to af1123e Feb 6, 2020
@cauemarcondes cauemarcondes requested a review from dgieselaar Feb 6, 2020
@cauemarcondes

This comment has been minimized.

Copy link
Contributor Author

cauemarcondes commented Feb 6, 2020

jenkins, retest this please

@cauemarcondes

This comment has been minimized.

Copy link
Contributor Author

cauemarcondes commented Feb 7, 2020

retest

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 7, 2020

💔 Build Failed


Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__.Transaction action menu shows required sections only

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected
+ Received

@@ -2,11 +2,11 @@
    Array [
      Object {
        "actions": Array [
          Object {
            "condition": true,
-           "href": "#/link-to/logs?time=1580943600000&filter=trace.id:%22123%22%20OR%20123",
+           "href": "#/link-to/logs?time=1580947200000&filter=trace.id:%22123%22%20OR%20123",
            "key": "traceLogs",
            "label": "Trace logs",
          },
        ],
        "key": "traceDetails",
    at Object.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__/sections.test.ts:30:7)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__.Transaction action menu shows pod and required sections only

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected
+ Received

@@ -2,11 +2,11 @@
    Array [
      Object {
        "actions": Array [
          Object {
            "condition": true,
-           "href": "#/link-to/pod-logs/123?time=1580943600000",
+           "href": "#/link-to/pod-logs/123?time=1580947200000",
            "key": "podLogs",
            "label": "Pod logs",
          },
          Object {
            "condition": true,
@@ -21,11 +21,11 @@
      },
      Object {
        "actions": Array [
          Object {
            "condition": true,
-           "href": "#/link-to/logs?time=1580943600000&filter=trace.id:%22123%22%20OR%20123",
+           "href": "#/link-to/logs?time=1580947200000&filter=trace.id:%22123%22%20OR%20123",
            "key": "traceLogs",
            "label": "Trace logs",
          },
        ],
        "key": "traceDetails",
    at Object.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__/sections.test.ts:78:7)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__.Transaction action menu shows host and required sections only

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected
+ Received

@@ -2,11 +2,11 @@
    Array [
      Object {
        "actions": Array [
          Object {
            "condition": true,
-           "href": "#/link-to/host-logs/foo?time=1580943600000",
+           "href": "#/link-to/host-logs/foo?time=1580947200000",
            "key": "hostLogs",
            "label": "Host logs",
          },
          Object {
            "condition": true,
@@ -21,11 +21,11 @@
      },
      Object {
        "actions": Array [
          Object {
            "condition": true,
-           "href": "#/link-to/logs?time=1580943600000&filter=trace.id:%22123%22%20OR%20123",
+           "href": "#/link-to/logs?time=1580947200000&filter=trace.id:%22123%22%20OR%20123",
            "key": "traceLogs",
            "label": "Trace logs",
          },
        ],
        "key": "traceDetails",
    at Object.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__/sections.test.ts:145:7)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Feb 7, 2020
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 7, 2020

💔 Build Failed


Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__.Transaction action menu shows required sections only

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected
+ Received

@@ -2,11 +2,11 @@
    Array [
      Object {
        "actions": Array [
          Object {
            "condition": true,
-           "href": "#/link-to/logs?time=1580979600000&filter=trace.id:%22123%22%20OR%20123",
+           "href": "#/link-to/logs?time=1580983200000&filter=trace.id:%22123%22%20OR%20123",
            "key": "traceLogs",
            "label": "Trace logs",
          },
        ],
        "key": "traceDetails",
    at Object.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__/sections.test.ts:35:7)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__.Transaction action menu shows pod and required sections only

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected
+ Received

@@ -2,11 +2,11 @@
    Array [
      Object {
        "actions": Array [
          Object {
            "condition": true,
-           "href": "#/link-to/pod-logs/123?time=1580979600000",
+           "href": "#/link-to/pod-logs/123?time=1580983200000",
            "key": "podLogs",
            "label": "Pod logs",
          },
          Object {
            "condition": true,
@@ -21,11 +21,11 @@
      },
      Object {
        "actions": Array [
          Object {
            "condition": true,
-           "href": "#/link-to/logs?time=1580979600000&filter=trace.id:%22123%22%20OR%20123",
+           "href": "#/link-to/logs?time=1580983200000&filter=trace.id:%22123%22%20OR%20123",
            "key": "traceLogs",
            "label": "Trace logs",
          },
        ],
        "key": "traceDetails",
    at Object.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__/sections.test.ts:83:7)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__.Transaction action menu shows host and required sections only

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected
+ Received

@@ -2,11 +2,11 @@
    Array [
      Object {
        "actions": Array [
          Object {
            "condition": true,
-           "href": "#/link-to/host-logs/foo?time=1580979600000",
+           "href": "#/link-to/host-logs/foo?time=1580983200000",
            "key": "hostLogs",
            "label": "Host logs",
          },
          Object {
            "condition": true,
@@ -21,11 +21,11 @@
      },
      Object {
        "actions": Array [
          Object {
            "condition": true,
-           "href": "#/link-to/logs?time=1580979600000&filter=trace.id:%22123%22%20OR%20123",
+           "href": "#/link-to/logs?time=1580983200000&filter=trace.id:%22123%22%20OR%20123",
            "key": "traceLogs",
            "label": "Trace logs",
          },
        ],
        "key": "traceDetails",
    at Object.it (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/__test__/sections.test.ts:150:7)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 7, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

dgieselaar left a comment

(forgot to submit this comment)

anchorPosition="downRight"
panelPaddingSize="none"
button={<ActionMenuButton onClick={() => setIsOpen(!isOpen)} />}

This comment has been minimized.

Copy link
@dgieselaar

dgieselaar Feb 7, 2020

Contributor

Ideally you would use the callback form of setState, see https://reactjs.org/docs/react-component.html#setstate

This comment has been minimized.

Copy link
@cauemarcondes

cauemarcondes Feb 7, 2020

Author Contributor

@dgieselaar even in a function component?

@cauemarcondes

This comment has been minimized.

Copy link
Contributor Author

cauemarcondes commented Feb 10, 2020

@elasticmachine merge upstream

@cauemarcondes cauemarcondes requested a review from dgieselaar Feb 10, 2020
@cauemarcondes cauemarcondes changed the title [APM UI] actions menu update [APM] Divide "Actions menu" into sections to improve readability Feb 10, 2020
@cauemarcondes cauemarcondes force-pushed the cauemarcondes:actions-menu branch from 29071a6 to 2293acf Feb 13, 2020
@cauemarcondes cauemarcondes requested a review from elastic/logs-metrics-ui as a code owner Feb 13, 2020
@cauemarcondes cauemarcondes requested a review from sqren Feb 13, 2020
{sections.map((section, idx) => (
<div key={idx}>
{section.map(item => (
<Section key={item.key} marginBottom={px(units.plus)}>

This comment has been minimized.

Copy link
@phillipb

phillipb Feb 13, 2020

Contributor

No need to add a marginBottom here, should just use the <SectionSpacer /> component https://github.com/elastic/kibana/blob/master/x-pack/plugins/observability/public/components/action_menu.tsx#L46

This comment has been minimized.

Copy link
@cauemarcondes

cauemarcondes Feb 13, 2020

Author Contributor

Thanks for your feedback @phillipb, I added the marginBottom property because I thought the Section component should automatically handle the space between sections for me. Then with CSS I remove the space from the last item.

https://github.com/cauemarcondes/kibana/blob/actions-menu/x-pack/plugins/observability/public/components/action_menu.tsx#L49-L56

This comment has been minimized.

Copy link
@phillipb

phillipb Feb 13, 2020

Contributor

ah, I see. That makes sense. What do you think about defaulting the marginBottom in the Section component, so others don't need to think about it?

This comment has been minimized.

Copy link
@cauemarcondes

cauemarcondes Feb 13, 2020

Author Contributor

They don't have to worry about it, the property is optional if it is missing it will use 0.

This comment has been minimized.

Copy link
@phillipb

phillipb Feb 13, 2020

Contributor

I just meant so that they get this behavior by default. This feels like the desired behavior to me, or is this APM specific?

This comment has been minimized.

Copy link
@sqren

sqren Feb 13, 2020

Member

I think the following is more readable:

<Section key={item.key}>
!isLast &&  <SectionSpacer />

Although using css is more performant... 🤔

This comment has been minimized.

Copy link
@sqren

sqren Feb 13, 2020

Member

In the javascript approach it's clear that we add a space after every section except the last one. That's not possible to see from:

<Section key={item.key} marginBottom={px(units.plus)}>

This comment has been minimized.

Copy link
@phillipb

phillipb Feb 13, 2020

Contributor

I don't have strong feelings about one approach over the other. I just think if we go with the css approach it should all be handled internally in the Section component. A marginBottom prop feels like an afterthought. Some future person will wonder why it's there and what they should set it to. I'd rather keep the api clean for consistency.

This comment has been minimized.

Copy link
@cauemarcondes

cauemarcondes Feb 14, 2020

Author Contributor

IMO, I expect the Service Component to handle that. Otherwise, what's the benefit that I have by using it? In the end, it just shows the children. Now if I start using it in other parts of the UI, every time I'd have to check if I'm in the last item of the list to not show the space. I agreed with @phillipb that we could add the margin-bottom by default in order to have a clear API. WDYT?

This comment has been minimized.

Copy link
@sqren

sqren Feb 14, 2020

Member

we could add the margin-bottom by default in order to have a clear API

👍

@sqren
sqren approved these changes Feb 14, 2020
@cauemarcondes cauemarcondes force-pushed the cauemarcondes:actions-menu branch from 381ec95 to 0ffd9a2 Feb 17, 2020
@kibanamachine

This comment has been minimized.

Copy link

kibanamachine commented Feb 17, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit f49581c into elastic:master Feb 17, 2020
54 checks passed
54 checks passed
API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:browser-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits passed the check
Details
Check core API changes node scripts/check_core_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Check lockfile symlinks node scripts/check_lockfile_symlinks --quiet
Details
Example functional tests node scripts/functional_tests --config test/examples/config.js --bail --debug
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.ts --bail --debug --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-1
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Kibana accessibility tests node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64 --config test/accessibility/config.ts
Details
Mocha tests node scripts/mocha
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug
Details
Project tests yarn run grunt test:projects
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-1 --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-10 --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-2 --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-3 --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-4 --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-5 --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-6 --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-7 --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-8 --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-9 --include-tag ciGroup9
Details
X-Pack Jest node scripts/jest --ci --verbose
Details
X-Pack Karma Tests yarn test:browser
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack accessibility tests node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana --config test/accessibility/config.ts
Details
elasticsearch-ci/docs Build finished.
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
prbot:outdated
prbot:release note labels
prbot:release version labels
sasslint node scripts/sasslint
Details
@cauemarcondes cauemarcondes deleted the cauemarcondes:actions-menu branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

9 participants
You can’t perform that action at this time.