From 59d3899cf7329755af5a49c44e80c06886ba3265 Mon Sep 17 00:00:00 2001 From: kobelb Date: Wed, 5 Feb 2020 13:36:10 -0800 Subject: [PATCH 1/3] Add autocomplete="off" for input type="password" to appease the scanners --- .../__snapshots__/basic_login_form.test.tsx.snap | 1 + .../login/components/basic_login_form/basic_login_form.tsx | 1 + .../components/change_password_form/change_password_form.tsx | 3 +++ 3 files changed, 5 insertions(+) diff --git a/x-pack/legacy/plugins/security/public/views/login/components/basic_login_form/__snapshots__/basic_login_form.test.tsx.snap b/x-pack/legacy/plugins/security/public/views/login/components/basic_login_form/__snapshots__/basic_login_form.test.tsx.snap index 9814a2a7784fc..b09f398ed5ed9 100644 --- a/x-pack/legacy/plugins/security/public/views/login/components/basic_login_form/__snapshots__/basic_login_form.test.tsx.snap +++ b/x-pack/legacy/plugins/security/public/views/login/components/basic_login_form/__snapshots__/basic_login_form.test.tsx.snap @@ -64,6 +64,7 @@ exports[`BasicLoginForm renders as expected 1`] = ` > { } > { } > { } > { } > Date: Mon, 10 Feb 2020 07:16:10 -0800 Subject: [PATCH 2/3] Using new-password instead of off for the new/confirm passwords --- .../components/change_password_form/change_password_form.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/security/public/management/users/components/change_password_form/change_password_form.tsx b/x-pack/plugins/security/public/management/users/components/change_password_form/change_password_form.tsx index 63726edeb7763..75621762b1b85 100644 --- a/x-pack/plugins/security/public/management/users/components/change_password_form/change_password_form.tsx +++ b/x-pack/plugins/security/public/management/users/components/change_password_form/change_password_form.tsx @@ -100,7 +100,7 @@ export class ChangePasswordForm extends Component { } > { } > Date: Mon, 10 Feb 2020 07:24:22 -0800 Subject: [PATCH 3/3] Setting more autoComplete="new-password" attributes --- .../public/management/users/edit_user/edit_user_page.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.tsx b/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.tsx index 576f3ff9e6008..8e7d9fb2dac08 100644 --- a/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.tsx +++ b/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.tsx @@ -204,6 +204,7 @@ export class EditUserPage extends Component { {...this.validator.validatePassword(this.state.user)} > { {...this.validator.validateConfirmPassword(this.state.user)} >