Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Use ES Permission API to check if a user has permissions to read from APM indices #57311

Open
wants to merge 8 commits into
base: master
from

Conversation

@cauemarcondes
Copy link
Contributor

cauemarcondes commented Feb 11, 2020

Server route: /api/apm/security/indices_privileges
I renamed all server-side from 'Permissions' to 'Privileges', since I'm going to return all privileges from APM indices. And in the client, I'll check if the user has permission based on the privileges.

Screenshot 2020-02-13 at 09 48 34

Screenshot 2020-02-13 at 09 51 22

Screenshot 2020-02-13 at 09 51 44

Screenshot 2020-02-13 at 09 53 33

@cauemarcondes cauemarcondes force-pushed the cauemarcondes:missing-permission branch from 5126d03 to b8aac58 Feb 13, 2020
@cauemarcondes cauemarcondes marked this pull request as ready for review Feb 13, 2020
@cauemarcondes cauemarcondes requested a review from elastic/apm-ui as a code owner Feb 13, 2020
@cauemarcondes cauemarcondes requested a review from sqren Feb 13, 2020
@sqren
sqren approved these changes Feb 14, 2020
Copy link
Member

sqren left a comment

LGTM. Just a few few copy changes

@cauemarcondes

This comment has been minimized.

Copy link
Contributor Author

cauemarcondes commented Feb 17, 2020

@elasticmachine merge upstream

elasticmachine and others added 2 commits Feb 17, 2020
@kibanamachine

This comment has been minimized.

Copy link

kibanamachine commented Feb 17, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sqren
sqren approved these changes Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.