Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix trace sample double pagination summary #57558

Open
wants to merge 6 commits into
base: master
from

Conversation

@formgeist
Copy link
Contributor

formgeist commented Feb 13, 2020

Summary

Fixes #57303

Due to an update in the EUI component, we are currently displaying double pagination summaries in the trace summary header. This removes the custom pagination header we implemented in APM UI.

Screenshot 2020-02-13 at 13 28 23

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@formgeist formgeist requested a review from elastic/apm-ui as a code owner Feb 13, 2020
@formgeist formgeist self-assigned this Feb 13, 2020
@elasticmachine

This comment has been minimized.

Copy link
Contributor

elasticmachine commented Feb 13, 2020

Pinging @elastic/apm-ui (Team:apm)

@sqren
sqren approved these changes Feb 13, 2020
Copy link
Member

sqren left a comment

Beautiful 🥇

@formgeist

This comment has been minimized.

Copy link
Contributor Author

formgeist commented Feb 17, 2020

@elasticmachine merge upstream

@formgeist

This comment has been minimized.

Copy link
Contributor Author

formgeist commented Feb 18, 2020

@elasticmachine merge upstream

@kibanamachine

This comment has been minimized.

Copy link

kibanamachine commented Feb 18, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.