From d26a5da252b4903f669d679c7af4bc4bc132a4e5 Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Tue, 10 Mar 2020 12:27:23 +0100 Subject: [PATCH] fix vega config issues --- src/legacy/core_plugins/vis_type_vega/index.ts | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/legacy/core_plugins/vis_type_vega/index.ts b/src/legacy/core_plugins/vis_type_vega/index.ts index ccef24f8f97465..ac7e407ca9e4dc 100644 --- a/src/legacy/core_plugins/vis_type_vega/index.ts +++ b/src/legacy/core_plugins/vis_type_vega/index.ts @@ -24,10 +24,16 @@ import { LegacyPluginApi, LegacyPluginInitializer } from '../../../../src/legacy const vegaPluginInitializer: LegacyPluginInitializer = ({ Plugin }: LegacyPluginApi) => new Plugin({ - // TODO: ID property should be changed from 'vega' to 'vis_type_vega' - // It is required to change the configuration property - // vega.enableExternalUrls -> vis_type_vega.enableExternalUrls - id: 'vega', + id: 'vis_type_vega', + deprecations: ({ rename }: { rename: any }) => [ + rename('vega.enabled', 'vis_type_vega.enabled'), + ], + config(Joi: any) { + return Joi.object({ + enabled: Joi.boolean().default(true), + enableExternalUrls: Joi.boolean().default(false), + }).default(); + }, require: ['kibana', 'elasticsearch'], publicDir: resolve(__dirname, 'public'), uiExports: {