Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Remote Agent Config: Add additional (java) options #59860

Merged
merged 37 commits into from Mar 23, 2020

Conversation

@sqren
Copy link
Member

sqren commented Mar 11, 2020

Closes: elastic/apm#214

TODO:

  • Agent specific options (only show option for specific services)
  • When selecting "All" services, only show options that are relevant to all backend agents (not considering RUM)
  • Highlight "Agent configuration" menu item when creating/editing config
  • Options are sorted alphabetically
  • Limit options by to specific agents (eg java specific options)
  • Discard button on settings page should reset settings
  • Cancel button on service page should take user to the list page (overview)
  • Bottom bar overflows the left hand navigation (waiting for EUI to add a prop, or allow arbitrary css) (elastic/eui#3146)
  • Review page (not for 7.7)
  • Config per agent name (not for 7.7)
  • Categories: list options under categories (not for 7.7)
  • Highlight previously edited options (not for 7.7)

Questions:

  • Are the descriptions the same across all agents?
  • Are the default values the same across all agents?

image

image

image

image

@sqren sqren marked this pull request as ready for review Mar 11, 2020
@sqren sqren requested a review from elastic/apm-ui as a code owner Mar 11, 2020
),
name: RouteName.AGENT_CONFIGURATION_CREATE,
component: () => {
const { search } = history.location;

This comment has been minimized.

Copy link
@sqren

sqren Mar 11, 2020

Author Member

Controversy #1: retrieving search from history singleton. Everywhere else we get it from useLocation hook.
The problem with hooks is that they only work inside react components (not vanilla js) so in general I think when given the choice it's better to use the singleton approach (for consistency).

afact there are no difference between the two approaches. LMK if there are!

return (
<EuiFieldNumber
placeholder={setting.placeholder || defaultInputPlaceholder}
value={(value as any) || ''}

This comment has been minimized.

Copy link
@sqren

sqren Mar 11, 2020

Author Member

EuiFieldNumber currently don't accept strings. This will change with this PR

@sqren sqren force-pushed the sqren:agent-configuration-additional-settings branch from 41032e6 to 259f363 Mar 11, 2020
@sqren sqren force-pushed the sqren:agent-configuration-additional-settings branch 2 times, most recently from b8cab16 to 44f18c8 Mar 16, 2020
sqren and others added 12 commits Mar 18, 2020
…Configurations/AgentConfigurationCreateEdit/ServicePage/ServicePage.tsx

Co-Authored-By: Casper Hübertz <casper@formgeist.com>
…Configurations/AgentConfigurationCreateEdit/ServicePage/ServicePage.tsx

Co-Authored-By: Casper Hübertz <casper@formgeist.com>
…Configurations/AgentConfigurationCreateEdit/ServicePage/ServicePage.tsx

Co-Authored-By: Casper Hübertz <casper@formgeist.com>
@sqren sqren force-pushed the sqren:agent-configuration-additional-settings branch from cc73feb to cb51fcc Mar 22, 2020
sqren added 2 commits Mar 22, 2020
@sqren

This comment has been minimized.

Copy link
Member Author

sqren commented Mar 23, 2020

If you have unsaved changes (which is the current behaviour), wouldn't it make more sense to cancel the edits and return to the create page where you started instead of sending the user back to the list page?

@formgeist

I'll change the Cancel button to be a Discard button while in edit mode. It will behave as described above.

WDYT should happen when creating a new config?

@formgeist

This comment has been minimized.

Copy link
Contributor

formgeist commented Mar 23, 2020

WDYT should happen when creating a new config?

If we're keeping the "discard" changes button even on a new config, the user would have to go back to the overview page via the sidenav to "cancel", as there's no specified cancel option. I don't think that's too big of an issue.

Copy link
Contributor

cauemarcondes left a comment

LGTM 👍🏻

@kibanamachine

This comment has been minimized.

Copy link

kibanamachine commented Mar 23, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sqren sqren merged commit 6535985 into elastic:master Mar 23, 2020
56 checks passed
56 checks passed
API integration tests node scripts/functional_tests --config test/api_integration/config.js --bail --debug
Details
Browser tests yarn run grunt test:karma-ci
Details
Build kbn_tp_sample_panel_action yarn build
Details
CLA All commits passed the check
Details
Check core API changes node scripts/check_published_api_changes
Details
Check file casing node scripts/check_file_casing --quiet
Details
Check licenses node scripts/check_licenses --dev
Details
Check lockfile symlinks node scripts/check_lockfile_symlinks --quiet
Details
Example functional tests node scripts/functional_tests --config test/examples/config.js --bail --debug
Details
Functional tests / Group 1 yarn run grunt run:functionalTests_ciGroup1
Details
Functional tests / Group 10 yarn run grunt run:functionalTests_ciGroup10
Details
Functional tests / Group 11 yarn run grunt run:functionalTests_ciGroup11
Details
Functional tests / Group 12 yarn run grunt run:functionalTests_ciGroup12
Details
Functional tests / Group 2 yarn run grunt run:functionalTests_ciGroup2
Details
Functional tests / Group 3 yarn run grunt run:functionalTests_ciGroup3
Details
Functional tests / Group 4 yarn run grunt run:functionalTests_ciGroup4
Details
Functional tests / Group 5 yarn run grunt run:functionalTests_ciGroup5
Details
Functional tests / Group 6 yarn run grunt run:functionalTests_ciGroup6
Details
Functional tests / Group 7 yarn run grunt run:functionalTests_ciGroup7
Details
Functional tests / Group 8 yarn run grunt run:functionalTests_ciGroup8
Details
Functional tests / Group 9 yarn run grunt run:functionalTests_ciGroup9
Details
Internationalization check node scripts/i18n_check --ignore-missing
Details
Interpreter functional tests node scripts/functional_tests --config test/interpreter_functional/config.ts --bail --debug --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64-1
Details
Jest integration tests yarn run grunt test:jest_integration
Details
Jest tests yarn run grunt test:jest
Details
Kibana accessibility tests node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/kibana/build/oss/kibana-8.0.0-SNAPSHOT-linux-x86_64 --config test/accessibility/config.ts
Details
Mocha tests node scripts/mocha
Details
Node.js hardening tests node scripts/test_hardening.js
Details
Plugin functional tests node scripts/functional_tests --config test/plugin_functional/config.js --bail --debug
Details
Project tests yarn run grunt test:projects
Details
SIEM Cypress Tests node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana- --config test/siem_cypress/config.ts
Details
Type check node scripts/type_check
Details
TypeScript - all files belong to a TypeScript project node scripts/check_ts_projects
Details
Verify NOTICE.txt node scripts/notice --validate
Details
Verify dependency versions yarn run grunt verifyDependencyVersions
Details
X-Pack Chrome Functional tests / Group 1 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-1 --include-tag ciGroup1
Details
X-Pack Chrome Functional tests / Group 10 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-10 --include-tag ciGroup10
Details
X-Pack Chrome Functional tests / Group 2 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-2 --include-tag ciGroup2
Details
X-Pack Chrome Functional tests / Group 3 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-3 --include-tag ciGroup3
Details
X-Pack Chrome Functional tests / Group 4 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-4 --include-tag ciGroup4
Details
X-Pack Chrome Functional tests / Group 5 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-5 --include-tag ciGroup5
Details
X-Pack Chrome Functional tests / Group 6 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-6 --include-tag ciGroup6
Details
X-Pack Chrome Functional tests / Group 7 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-7 --include-tag ciGroup7
Details
X-Pack Chrome Functional tests / Group 8 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-8 --include-tag ciGroup8
Details
X-Pack Chrome Functional tests / Group 9 node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana-9 --include-tag ciGroup9
Details
X-Pack Jest node --max-old-space-size=6144 scripts/jest --ci --verbose --detectOpenHandles
Details
X-Pack Karma Tests yarn test:karma
Details
X-Pack SIEM cyclic dependency test node legacy/plugins/siem/scripts/check_circular_deps
Details
X-Pack accessibility tests node scripts/functional_tests --debug --bail --kibana-install-dir /dev/shm/workspace/install/kibana --config test/accessibility/config.ts
Details
elasticsearch-ci/docs Build finished.
Details
eslint node scripts/eslint --no-cache
Details
kibana-ci Build finished.
Details
prbot:outdated
prbot:release note labels
prbot:release version labels
sasslint node scripts/sasslint
Details
@sqren sqren deleted the sqren:agent-configuration-additional-settings branch Mar 23, 2020
sqren added a commit that referenced this pull request Mar 23, 2020
@jalvz jalvz mentioned this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

8 participants
You can’t perform that action at this time.