Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Show joins disabled message #70826

Merged
merged 12 commits into from Jul 13, 2020
Merged

[Maps] Show joins disabled message #70826

merged 12 commits into from Jul 13, 2020

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Jul 6, 2020 •
edited

Replaces #70530

Fixes #61471

Display callout when joins are disabled.

Screen Shot 2020-07-01 at 4 27 13 PM

@thomasneirynck thomasneirynck requested a review from a team as a code owner July 6, 2020 15:54
@thomasneirynck thomasneirynck added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Jul 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck mentioned this pull request Jul 6, 2020
Closed
@thomasneirynck
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kindsun
kindsun approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm! works as expected and code looks good

  • code review
  • tested locally in chrome

@kindsun
Copy link
Contributor

kindsun commented Jul 13, 2020

I am getting one warning when creating a join. It doesn't seem to affect functionality but might be worth fixing:

image

@nreese
Copy link
Contributor

nreese commented Jul 13, 2020

I am getting one warning when creating a join. It doesn't seem to affect functionality but might be worth fixing:

Warning is also in master and unrelated to changes. This can be fixed in a separate PR

@thomasneirynck thomasneirynck merged commit c44f019 into elastic:master Jul 13, 2020
@thomasneirynck thomasneirynck mentioned this pull request Jul 13, 2020
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jul 13, 2020
@thomasneirynck
[Maps] Show joins disabled message (elastic#70826)
9466612 
Show feedback in the layer-settings when the scaling-method does not support Term-joins.
thomasneirynck added a commit that referenced this pull request Jul 13, 2020
@thomasneirynck
[Maps] Show joins disabled message (#70826) (#71473)
31c2595 
Show feedback in the layer-settings when the scaling-method does not support Term-joins.
@nreese nreese mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindsun kindsun kindsun approved these changes

@nreese nreese Awaiting requested review from nreese

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Do not hide "term join" card for blended layers
5 participants
@thomasneirynck @elasticmachine @kibanamachine @kindsun @nreese