Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusion of source fields #7402

Merged
merged 54 commits into from Nov 1, 2016
Merged

Exclusion of source fields #7402

merged 54 commits into from Nov 1, 2016

Conversation

scampi
Copy link
Contributor

@scampi scampi commented Jun 9, 2016

This PR adds filtering capability of source fields for a given index pattern. Excluded fields are then not retrieved by a saved search. However, looking at a document using the doc API displays all available fields.

In the index settings, a new column excluded is added which indicates if a field is excluded or not. In the picture, the born field is excluded. There is also a new tab source filters which shows all the exclusion patterns.

2016-10-06-232257_1200x729_scrot

Below is the source filters tab which shows on the left side the filter pattern, as well as the fields that match.

2016-10-06-232312_1200x729_scrot

On the discover page, I had created a saved search showing the field born. It is now empty since it is excluded.

2016-10-06-232334_1200x729_scrot

However, if you look at a specific document, all available fields are displayed.

2016-10-06-232352_1200x729_scrot

close #4366.
Reimplementation of #5981.

scampi and others added 25 commits June 2, 2016 21:07
…en on 'Filter fields' tab. Removed exclusion checkbox in the field controls page. Corrected typos. Improved documentation phrasing.
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@scampi scampi mentioned this pull request Jun 9, 2016
4 tasks
@scampi
Copy link
Contributor Author

scampi commented Jun 9, 2016

Errors in jenkins seem unrelated to this PR. I see many of the following:

TypeError: _this.saveScreenshot(...).finally is not a function
  at Command.<anonymous>  <test/support/pages/common.js:259:17>
  at runCallback  <node_modules/intern/node_modules/leadfoot/Command.js:526:31>
  at Command.<anonymous>  <node_modules/intern/node_modules/leadfoot/Command.js:545:11>
  at <node_modules/intern/node_modules/dojo/Promise.ts:393:15>
  at run  <node_modules/intern/node_modules/dojo/Promise.ts:237:7>
  at <node_modules/intern/node_modules/dojo/nextTick.ts:44:3>
  at nextTickCallbackWith0Args  <node.js:420:9>
  at process._tickCallback  <node.js:349:13>
  at Command.then  <node_modules/intern/node_modules/leadfoot/Command.js:542:10>
  at Command.catch  <node_modules/intern/node_modules/leadfoot/Command.js:556:15>
  at Test.test  <test/functional/apps/discover/_shared_links.js:132:17>
  at <node_modules/intern/lib/Test.js:211:24>
  at <node_modules/intern/node_modules/dojo/Promise.ts:393:15>
  at runCallbacks  <node_modules/intern/node_modules/dojo/Promise.ts:11:11>
  at <node_modules/intern/node_modules/dojo/Promise.ts:317:4>
  at run  <node_modules/intern/node_modules/dojo/Promise.ts:237:7>
  at <node_modules/intern/node_modules/dojo/nextTick.ts:44:3>
  at nextTickCallbackWith0Args  <node.js:420:9>
  at process._tickCallback  <node.js:349:13>

@LeeDr
Copy link
Contributor

LeeDr commented Jun 9, 2016

The first failure screenshot shows this;
failure_1465461668876_query_save query should show toast message and display query name

The test failed to find the toast message "Discover: Saved Data Source "Query # 1" even though it is there, because there's another toast error message that says "! Discover: this.fieldFilters is undefined".

I haven't figured out why that message is being displayed. But it looks like it might be related to this PR.

@spalger
Copy link
Contributor

spalger commented Oct 25, 2016

jenkins, test this

@spalger
Copy link
Contributor

spalger commented Oct 28, 2016

@Bargs can you take another look at this?

@Bargs
Copy link
Contributor

Bargs commented Oct 31, 2016

Just one last thought:

Note that multi-fields will incorrectly appear as matches in the table below. These filters only actually apply to fields in the original source document, so matching multi-fields are not actually being filtered.

Now that we're putting this front and center, I think we should remove the special treatment of .raw and .keyword fields. Then at least our descriptive text and code will be consistent and hopefully less magical/confusing to users who are trying to understand how this works.

@Bargs Bargs mentioned this pull request Oct 31, 2016
@scampi
Copy link
Contributor Author

scampi commented Nov 1, 2016

@Bargs I removed the logic about raw and keyword fields.

@Bargs
Copy link
Contributor

Bargs commented Nov 1, 2016

LGTM. How about you @spalger ?

@spalger
Copy link
Contributor

spalger commented Nov 1, 2016

big +1, LGTM!

@spalger spalger merged commit 0b877f6 into elastic:master Nov 1, 2016
elastic-jasper added a commit that referenced this pull request Nov 1, 2016
Backports PR #7402

**Commit 1:**
added source filtering

* Original sha: e7204be
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-01-12T10:08:35Z

**Commit 2:**
ditched the new 'retrieved fields' tab and added checkbox to exclude a field in the field control

* Original sha: b228c66
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-01-13T14:44:38Z

**Commit 3:**
disable field exclusion checkbox if field is a metafield

* Original sha: 0d06220
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-01-15T15:39:47Z

**Commit 4:**
[indexPattern] copy excluded field property when refreshing fields

* Original sha: c3c1d48
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:01:48Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:40:15Z

**Commit 5:**
[indexPattern/field] move isMetaField consideration into Field

* Original sha: 5b0b00a
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:22:52Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:44:37Z

**Commit 6:**
[indexPattern/edit] invert the "retreived" column, for accuracy

* Original sha: 1dee6f1
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:24:44Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:47:21Z

**Commit 7:**
[indexPattern/field] touchup the field.exclude message

* Original sha: ec0c334
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:25:24Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:47:23Z

**Commit 8:**
Fix typo

* Original sha: 062931a
* Authored by Spencer <spalger@users.noreply.github.com> on 2016-01-21T19:33:14Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:48:53Z

**Commit 9:**
[indexPattern] handle index patterns without fields

* Original sha: 9d70208
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-22T18:27:45Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:51:11Z

**Commit 10:**
[courier/searchSource] auto add source filter for index pattern

* Original sha: 5a97b6b
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-23T01:08:52Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:04:09Z

**Commit 11:**
[docTable] remove irrelevant test about source filtering

* Original sha: 8211990
* Authored by spalger <spalger@users.noreply.github.com> on 2016-02-12T08:17:56Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:04:11Z

**Commit 12:**
[settings/indices] cleanup imports

* Original sha: fa5b22d
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T00:29:36Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:06:11Z

**Commit 13:**
[settings/indexPattern/fields] add "field filters" tab

* Original sha: 7819fa9
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T06:07:31Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:20Z

**Commit 14:**
[imports] fix old testUtils import

* Original sha: d4b9c11
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T06:08:46Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:24Z

**Commit 15:**
[ui/fieldWildcard] add lib to match names based on field-style wildcards

* Original sha: d75a63f
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T08:02:01Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:24Z

**Commit 16:**
[settings/fieldFilters] list filter matches, remove excluded fields from fieldata_fields

* Original sha: 08f8fd7
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T08:59:39Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:24Z

**Commit 17:**
[fieldWildcard] properly escape regexp control chars

* Original sha: 385a062
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T09:13:21Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 18:**
[settings/indexPatterns] mark fields excluded if they match an exclude pattern

* Original sha: da62b2a
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T09:29:03Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 19:**
[fieldWildcard] properly bind the regexp to the ends

* Original sha: e89ceea
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T23:59:06Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 20:**
[indexPattern] remove unneeded lodash chain

* Original sha: 14d5458
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-06T00:00:28Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 21:**
[settings/indices] use settings-indices- prefix for tab direcives

* Original sha: dc53a10
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-06T00:03:45Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:12:19Z

**Commit 22:**
corrected rebase on master

* Original sha: 4be31b2
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:29:19Z

**Commit 23:**
Do not match exclusion on meta/scripted fields. Disable filter bar when on 'Filter fields' tab. Removed exclusion checkbox in the field controls page. Corrected typos. Improved documentation phrasing.

* Original sha: 79e87ca
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:14:12Z

**Commit 24:**
Merge branch 'master' into issue4366

* Original sha: 984d334
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:29:38Z

**Commit 25:**
corrected error in merge with _index_pattern

* Original sha: 3375fd1
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:35:25Z

**Commit 26:**
removed unused code

* Original sha: 6a0b331
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:56:56Z

**Commit 27:**
Merge branch 'master' into issue4366

* Original sha: 81a56f9
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T21:24:12Z

**Commit 28:**
added missing fieldFilters to test dumps

* Original sha: c209ce3
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-11T09:14:10Z

**Commit 29:**
Merge branch 'master' into issue4366

* Original sha: 9511486
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-13T08:57:50Z

**Commit 30:**
added the management section refactoring from master

* Original sha: 9e32bbc
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-30T09:14:19Z
@scampi scampi deleted the issue4366 branch November 1, 2016 17:49
spalger pushed a commit that referenced this pull request Nov 1, 2016
Backports PR #7402

**Commit 1:**
added source filtering

* Original sha: e7204be
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-01-12T10:08:35Z

**Commit 2:**
ditched the new 'retrieved fields' tab and added checkbox to exclude a field in the field control

* Original sha: b228c66
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-01-13T14:44:38Z

**Commit 3:**
disable field exclusion checkbox if field is a metafield

* Original sha: 0d06220
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-01-15T15:39:47Z

**Commit 4:**
[indexPattern] copy excluded field property when refreshing fields

* Original sha: c3c1d48
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:01:48Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:40:15Z

**Commit 5:**
[indexPattern/field] move isMetaField consideration into Field

* Original sha: 5b0b00a
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:22:52Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:44:37Z

**Commit 6:**
[indexPattern/edit] invert the "retreived" column, for accuracy

* Original sha: 1dee6f1
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:24:44Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:47:21Z

**Commit 7:**
[indexPattern/field] touchup the field.exclude message

* Original sha: ec0c334
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:25:24Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:47:23Z

**Commit 8:**
Fix typo

* Original sha: 062931a
* Authored by Spencer <spalger@users.noreply.github.com> on 2016-01-21T19:33:14Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:48:53Z

**Commit 9:**
[indexPattern] handle index patterns without fields

* Original sha: 9d70208
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-22T18:27:45Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:51:11Z

**Commit 10:**
[courier/searchSource] auto add source filter for index pattern

* Original sha: 5a97b6b
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-23T01:08:52Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:04:09Z

**Commit 11:**
[docTable] remove irrelevant test about source filtering

* Original sha: 8211990
* Authored by spalger <spalger@users.noreply.github.com> on 2016-02-12T08:17:56Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:04:11Z

**Commit 12:**
[settings/indices] cleanup imports

* Original sha: fa5b22d
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T00:29:36Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:06:11Z

**Commit 13:**
[settings/indexPattern/fields] add "field filters" tab

* Original sha: 7819fa9
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T06:07:31Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:20Z

**Commit 14:**
[imports] fix old testUtils import

* Original sha: d4b9c11
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T06:08:46Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:24Z

**Commit 15:**
[ui/fieldWildcard] add lib to match names based on field-style wildcards

* Original sha: d75a63f
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T08:02:01Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:24Z

**Commit 16:**
[settings/fieldFilters] list filter matches, remove excluded fields from fieldata_fields

* Original sha: 08f8fd7
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T08:59:39Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:24Z

**Commit 17:**
[fieldWildcard] properly escape regexp control chars

* Original sha: 385a062
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T09:13:21Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 18:**
[settings/indexPatterns] mark fields excluded if they match an exclude pattern

* Original sha: da62b2a
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T09:29:03Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 19:**
[fieldWildcard] properly bind the regexp to the ends

* Original sha: e89ceea
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T23:59:06Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 20:**
[indexPattern] remove unneeded lodash chain

* Original sha: 14d5458
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-06T00:00:28Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 21:**
[settings/indices] use settings-indices- prefix for tab direcives

* Original sha: dc53a10
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-06T00:03:45Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:12:19Z

**Commit 22:**
corrected rebase on master

* Original sha: 4be31b2
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:29:19Z

**Commit 23:**
Do not match exclusion on meta/scripted fields. Disable filter bar when on 'Filter fields' tab. Removed exclusion checkbox in the field controls page. Corrected typos. Improved documentation phrasing.

* Original sha: 79e87ca
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:14:12Z

**Commit 24:**
Merge branch 'master' into issue4366

* Original sha: 984d334
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:29:38Z

**Commit 25:**
corrected error in merge with _index_pattern

* Original sha: 3375fd1
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:35:25Z

**Commit 26:**
removed unused code

* Original sha: 6a0b331
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:56:56Z

**Commit 27:**
Merge branch 'master' into issue4366

* Original sha: 81a56f9
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T21:24:12Z

**Commit 28:**
added missing fieldFilters to test dumps

* Original sha: c209ce3
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-11T09:14:10Z

**Commit 29:**
Merge branch 'master' into issue4366

* Original sha: 9511486
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-13T08:57:50Z

**Commit 30:**
added the management section refactoring from master

* Original sha: 9e32bbc
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-30T09:14:19Z
@Bargs
Copy link
Contributor

Bargs commented Nov 1, 2016

🎉 🎉 🎉 🎉

@epixa
Copy link
Contributor

epixa commented Nov 2, 2016

@scampi Thanks for sticking with this PR to the end. This will help a lot of people.

nreese pushed a commit to nreese/kibana that referenced this pull request Nov 10, 2016
* added source filtering

* ditched the new 'retrieved fields' tab and added checkbox to exclude a field in the field control

* disable field exclusion checkbox if field is a metafield

* [indexPattern] copy excluded field property when refreshing fields

* [indexPattern/field] move isMetaField consideration into Field

* [indexPattern/edit] invert the "retreived" column, for accuracy

* [indexPattern/field] touchup the field.exclude message

* Fix typo

* [indexPattern] handle index patterns without fields

* [courier/searchSource] auto add source filter for index pattern

* [docTable] remove irrelevant test about source filtering

* [settings/indices] cleanup imports

* [settings/indexPattern/fields] add "field filters" tab

* [imports] fix old testUtils import

* [ui/fieldWildcard] add lib to match names based on field-style wildcards

* [settings/fieldFilters] list filter matches, remove excluded fields from fieldata_fields

* [fieldWildcard] properly escape regexp control chars

* [settings/indexPatterns] mark fields excluded if they match an exclude pattern

* [fieldWildcard] properly bind the regexp to the ends

* [indexPattern] remove unneeded lodash chain

* [settings/indices] use settings-indices- prefix for tab direcives

* corrected rebase on master

* Do not match exclusion on meta/scripted fields. Disable filter bar when on 'Filter fields' tab. Removed exclusion checkbox in the field controls page. Corrected typos. Improved documentation phrasing.

* corrected error in merge with _index_pattern

* removed unused code

* added missing fieldFilters to test dumps

* corrected merge with master

* removed default empty array in the index pattern schema, and check if fieldFilters exists

* restricts the source with the exclusion patterns set for that index pattern

* renamed field filters to source filters and explicitely retrieve the source in the doc controller

* renamed variables/moved files from field filters to source filters

* Renamed _field_types.js to _edit_sections.js to better reflect what it is for. Corrected editting typo. Renamed exclude column name to excluded. Corrected HTML styling. Removed unused config parameters in field_wildcard.

* Removed lines that were specifying the _source field since they were made unnecessary by https://github.com/elastic/kibana/pull/7402/files#diff-d1695ba2026ff89878f9e4f4de683758R50

* moved fielddata_fields source filtering to where it is initialized

* two-column layout for the source filters indices section

* corrected tests

* use the same table layout as in the other index sections.
Filter input correctly restricts source filters.
Do not match .keyword fields.

* Filter out .raw suffix from possible matches.
Removed unused HTML file.
Corrected bug that allowed to save an empty source filter.

* exclude is deprecated, should be excludes

* improved description

* changed as per code review

* removed filtering logic for keyword and raw fields
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
Backports PR elastic#7402

**Commit 1:**
added source filtering

* Original sha: e7204be
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-01-12T10:08:35Z

**Commit 2:**
ditched the new 'retrieved fields' tab and added checkbox to exclude a field in the field control

* Original sha: b228c66
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-01-13T14:44:38Z

**Commit 3:**
disable field exclusion checkbox if field is a metafield

* Original sha: 0d06220
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-01-15T15:39:47Z

**Commit 4:**
[indexPattern] copy excluded field property when refreshing fields

* Original sha: c3c1d48
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:01:48Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:40:15Z

**Commit 5:**
[indexPattern/field] move isMetaField consideration into Field

* Original sha: 5b0b00a
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:22:52Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:44:37Z

**Commit 6:**
[indexPattern/edit] invert the "retreived" column, for accuracy

* Original sha: 1dee6f1
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:24:44Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:47:21Z

**Commit 7:**
[indexPattern/field] touchup the field.exclude message

* Original sha: ec0c334
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-21T16:25:24Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:47:23Z

**Commit 8:**
Fix typo

* Original sha: 062931a
* Authored by Spencer <spalger@users.noreply.github.com> on 2016-01-21T19:33:14Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:48:53Z

**Commit 9:**
[indexPattern] handle index patterns without fields

* Original sha: 9d70208
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-22T18:27:45Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T20:51:11Z

**Commit 10:**
[courier/searchSource] auto add source filter for index pattern

* Original sha: 5a97b6b
* Authored by spalger <spalger@users.noreply.github.com> on 2016-01-23T01:08:52Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:04:09Z

**Commit 11:**
[docTable] remove irrelevant test about source filtering

* Original sha: 8211990
* Authored by spalger <spalger@users.noreply.github.com> on 2016-02-12T08:17:56Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:04:11Z

**Commit 12:**
[settings/indices] cleanup imports

* Original sha: fa5b22d
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T00:29:36Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:06:11Z

**Commit 13:**
[settings/indexPattern/fields] add "field filters" tab

* Original sha: 7819fa9
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T06:07:31Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:20Z

**Commit 14:**
[imports] fix old testUtils import

* Original sha: d4b9c11
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T06:08:46Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:24Z

**Commit 15:**
[ui/fieldWildcard] add lib to match names based on field-style wildcards

* Original sha: d75a63f
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T08:02:01Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:24Z

**Commit 16:**
[settings/fieldFilters] list filter matches, remove excluded fields from fieldata_fields

* Original sha: 08f8fd7
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T08:59:39Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:24Z

**Commit 17:**
[fieldWildcard] properly escape regexp control chars

* Original sha: 385a062
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T09:13:21Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 18:**
[settings/indexPatterns] mark fields excluded if they match an exclude pattern

* Original sha: da62b2a
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T09:29:03Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 19:**
[fieldWildcard] properly bind the regexp to the ends

* Original sha: e89ceea
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-05T23:59:06Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 20:**
[indexPattern] remove unneeded lodash chain

* Original sha: 14d5458
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-06T00:00:28Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:11:25Z

**Commit 21:**
[settings/indices] use settings-indices- prefix for tab direcives

* Original sha: dc53a10
* Authored by spalger <spalger@users.noreply.github.com> on 2016-04-06T00:03:45Z
* Committed by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:12:19Z

**Commit 22:**
corrected rebase on master

* Original sha: 4be31b2
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-02T21:29:19Z

**Commit 23:**
Do not match exclusion on meta/scripted fields. Disable filter bar when on 'Filter fields' tab. Removed exclusion checkbox in the field controls page. Corrected typos. Improved documentation phrasing.

* Original sha: 79e87ca
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:14:12Z

**Commit 24:**
Merge branch 'master' into issue4366

* Original sha: 984d334
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:29:38Z

**Commit 25:**
corrected error in merge with _index_pattern

* Original sha: 3375fd1
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:35:25Z

**Commit 26:**
removed unused code

* Original sha: 6a0b331
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T08:56:56Z

**Commit 27:**
Merge branch 'master' into issue4366

* Original sha: 81a56f9
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-09T21:24:12Z

**Commit 28:**
added missing fieldFilters to test dumps

* Original sha: c209ce3
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-11T09:14:10Z

**Commit 29:**
Merge branch 'master' into issue4366

* Original sha: 9511486
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-13T08:57:50Z

**Commit 30:**
added the management section refactoring from master

* Original sha: 9e32bbc
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-30T09:14:19Z

Former-commit-id: b3e0138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading huge documents
10 participants