Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vega is now GA #75157

Merged
merged 7 commits into from Aug 20, 2020
Merged

Vega is now GA #75157

merged 7 commits into from Aug 20, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Aug 17, 2020 •
edited by timroes

Closes: #21721

Release Summary

We have introduced Vega visualizations in Kibana 6.2 as experimental visualizations as of this versions this visualization is no longer experimental. This includes a couple of fixes for outstanding issues (like dark theme support) and adding an inspector to help debugging your Vega specification (https://www.elastic.co/guide/en/kibana/7.10/vega-reference.html#_vega_debugging).

Note to docs: this links should become valid as soon as 7.10 docs are published.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@alexwizp alexwizp self-assigned this Aug 17, 2020
@alexwizp alexwizp added Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 17, 2020
@alexwizp alexwizp added this to In progress in Kibana-app-np-migration via automation Aug 17, 2020
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

alexwizp
alexwizp commented Aug 18, 2020
View reviewed changes
test/functional/page_objects/vega_chart_page.ts
@@ -83,20 +91,16 @@ export function VegaChartPageProvider({
}

public async typeInSpec(text: string) {
await this.focusEditor();
Copy link
Contributor Author

@alexwizp alexwizp Aug 18, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but after removing the experimental flag, this method becomes unstable. @flash1293 could you please review my fix? And if possible run that test suite 20 times to be sure that it's not fluky

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running via https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/783/ (ciGroup9, containing the _vega_chart test file)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build was successful https://kibana-ci.elastic.co/view/All/job/kibana+flaky-test-suite-runner/788/console

@alexwizp alexwizp marked this pull request as ready for review August 18, 2020 09:04
@alexwizp alexwizp requested a review from a team August 18, 2020 09:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes changed the title Bringing Vega out of experimental Vega is now GA Aug 19, 2020
timroes
timroes approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and Tests LGTM

stratoula
stratoula approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick check on Safari, LGTM 🎉

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp alexwizp merged commit d158692 into elastic:master Aug 20, 2020
Kibana-app-np-migration automation moved this from In progress to Done Aug 20, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Aug 20, 2020
@alexwizp @elasticmachine
Vega is now GA (elastic#75157)
cdf5f32 
* Bringing Vega out of experimental

Closes: elastic#21721

* fix CI group 12

* remove experimental flag from doc

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@alexwizp alexwizp mentioned this pull request Aug 20, 2020
Merged
alexwizp added a commit that referenced this pull request Aug 20, 2020
@alexwizp @elasticmachine
Vega is now GA (#75157) (#75535)
152dffc 
* Bringing Vega out of experimental

Closes: #21721

* fix CI group 12

* remove experimental flag from doc

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
visTypeVega 661.8KB -21.0B 661.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf mentioned this pull request Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@stratoula stratoula stratoula approved these changes

@flash1293 flash1293 Awaiting requested review from flash1293

@timductive timductive Awaiting requested review from timductive

@AlonaNadler AlonaNadler Awaiting requested review from AlonaNadler

Assignees

@alexwizp alexwizp

Labels
Feature:Vega Vega visualizations release highlight release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
Kibana-app-np-migration
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bringing Vega out of experimental
5 participants
@alexwizp @elasticmachine @kibanamachine @timroes @stratoula