Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Update broken job config callout error #75481

Merged
merged 3 commits into from Aug 20, 2020
Merged

[ML] Update broken job config callout error #75481

merged 3 commits into from Aug 20, 2020

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Aug 19, 2020

Summary

Fix the call out link to the index management page not going to the right path. Currently it will go to app/ml/data_frame_analytics/management/kibana/indexPatterns instead of app/management/kibana/indexPatterns

image

@qn895 qn895 requested a review from a team as a code owner August 19, 2020 18:54
@qn895 qn895 self-assigned this Aug 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87
alvarezmelissa87 approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

peteharverson
peteharverson approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895
Copy link
Member Author

qn895 commented Aug 20, 2020

@elasticmachine merge upstream

@qn895
Copy link
Member Author

qn895 commented Aug 20, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.2MB +494.0B 8.2MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895 qn895 merged commit 958296c into elastic:master Aug 20, 2020
@qn895 qn895 deleted the ml-broken-callout-url branch August 20, 2020 23:15
@qn895 qn895 mentioned this pull request Aug 20, 2020
Merged
qn895 added a commit to qn895/kibana that referenced this pull request Aug 20, 2020
@qn895 @elasticmachine
[ML] Update broken job config callout error (elastic#75481)
4846ed6 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
qn895 added a commit that referenced this pull request Aug 21, 2020
@qn895 @elasticmachine
[7.x] [ML] Update broken job config callout error (#75481) (#75617)
e3644b2 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Aug 21, 2020
@qn895 @elasticmachine @thomasneirynck
[ML] Update broken job config callout error (elastic#75481)
4ac998f 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@qn895 qn895

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qn895 @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson