Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put APM links into header action menu #82292

Merged
merged 33 commits into from Nov 11, 2020
Merged

Conversation

smith
Copy link
Contributor

@smith smith commented Nov 2, 2020

APM

  • Move icons that were next to the heading into the header menu (opposite the breadcrumbs)
  • Since the action menu is mounted in a separate React tree outside of the normal router context, use react-reverse-portal to mount it there.
  • In the anomaly detection setup link, instead of showing a separate warning icon when anomaly detection is not set up, change the inspect icon to a warning icon.
  • Change the "Add data" icon to use the same icon as shown on the Kibana home page
  • Use a single alerting popover component (there were two very similar ones for home and service details, but now it just conditionally shows the transaction duration item based on whether a service name is present.)
  • Make alert popover close on click when opened
  • Include appMountParameters (which includes history and setHeaderActionMenu) in the APM and UX plugin contexts.
  • Remove the isServiceMapEnabled check from the home tabs and make it a constant instead of a function.

Before

image

After

image

Observability

  • Move feedback link into setHelpExtension menu
  • Move add data link into action menu
  • Move date picker up into the same level as the heading
  • Fix filename of "data_picker" to "date_picker"

Before

image

After

image

References #81954.

@smith smith marked this pull request as ready for review November 5, 2020 16:44
@smith smith requested review from a team as code owners November 5, 2020 16:44
@smith smith added release_note:skip Skip the PR/issue when compiling release notes release_note:enhancement v7.11.0 v8.0.0 and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 5, 2020
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 5, 2020
@smith
Copy link
Contributor Author

smith commented Nov 6, 2020

retest

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one question around useServiceName

@smith
Copy link
Contributor Author

smith commented Nov 6, 2020

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Nov 8, 2020

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Nov 10, 2020

@sqren @shahzad31 I updated this to use the reverse portal. Please re-review.

@smith
Copy link
Contributor Author

smith commented Nov 10, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1275 1274 -1
observability 106 108 +2
total +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB -7.1KB
observability 160.8KB 160.8KB -56.0B
total -7.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 66.9KB 71.3KB +4.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 5ab41f5 into elastic:master Nov 11, 2020
@smith smith deleted the nls/header-links branch November 11, 2020 01:16
smith added a commit to smith/kibana that referenced this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants