New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Case] Create comment types #82715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:plugin_api_changes
Contains a Plugin API changes section for the breaking plugin API changes section.
v8.0.0
v7.11.0
Team:Threat Hunting
Security Solution Threat Hunting Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
labels
Nov 5, 2020
8 tasks
@elasticmachine merge upstream |
1 similar comment
@elasticmachine merge upstream |
cnasikas
force-pushed
the
case_change_comments
branch
3 times, most recently
from
November 19, 2020 20:25
309cb53
to
907387c
Compare
cnasikas
changed the title
[Security Solution][Case] Add savedObjectId to comment
[Security Solution][Case] Create comment types
Nov 19, 2020
cnasikas
force-pushed
the
case_change_comments
branch
from
November 19, 2020 20:41
907387c
to
0ba4f95
Compare
cnasikas
force-pushed
the
case_change_comments
branch
from
November 20, 2020 10:56
1346434
to
7be1136
Compare
XavierM
reviewed
Nov 20, 2020
XavierM
reviewed
Nov 20, 2020
XavierM
reviewed
Nov 20, 2020
x-pack/plugins/security_solution/public/cases/containers/api.test.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Nov 20, 2020
x-pack/plugins/security_solution/public/cases/containers/api.ts
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Nov 20, 2020
XavierM
reviewed
Nov 20, 2020
XavierM
reviewed
Nov 20, 2020
XavierM
approved these changes
Nov 20, 2020
cnasikas
force-pushed
the
case_change_comments
branch
from
November 20, 2020 17:14
dbaba7e
to
bafe66c
Compare
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Nov 20, 2020
cnasikas
added a commit
that referenced
this pull request
Nov 20, 2020
💔 Build Failed
Failed CI Steps
Test FailuresFirefox UI Functional Tests.test/functional/apps/dashboard/dashboard_save·js.dashboard app using legacy data dashboard save warns on duplicate name for new dashboardStandard Out
Stack Trace
Firefox UI Functional Tests.test/functional/apps/dashboard/index·js.dashboard app using legacy data "after all" hook: unloadLogstash in "using legacy data"Standard Out
Stack Trace
Chrome UI Functional Tests.test/functional/apps/visualize/index·ts.visualize app "before all" hook in ""Standard Out
Stack Trace
and 9 more failures, only showing the first 3. Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:plugin_api_changes
Contains a Plugin API changes section for the breaking plugin API changes section.
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting
Security Solution Threat Hunting Team
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces comments' types. Specifically:
This will allow alerts or other features to be attached to a case.
Dev docs
To create or update a comment you need to provide the type of comment along with all needed attributes of each type. Specifically:
user
|alert
user
.alert
alert
Note: Only alerts (signals) of Security Solution are supported.
Checklist
Delete any items that are not applicable to this PR.
For maintainers