Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0. #8339

Merged
merged 1 commit into from Sep 20, 2016

Conversation

Projects
None yet
4 participants
@cjcenizal
Copy link
Contributor

cjcenizal commented Sep 19, 2016

Addresses #8330

Changes

  • Display feedback if a Dashboard or Visualization is loaded that already violates this constraint.
  • Add ElasticsearchError class and isTermSizeZeroError helper.

image

@cjcenizal cjcenizal force-pushed the cjcenizal:8330/bug/term-agg-size-0 branch from 743efcf to fa12b92 Sep 20, 2016

Set minimum aggregation 'Size' input value to 1, because ES will retu…
…rn an error if you provide a size of 0.

- Display feedback if a Dashboard or Visualization is loaded that already violates this constraint.
- Add ElasticsearchError class and isTermSizeZeroError helper.

@cjcenizal cjcenizal force-pushed the cjcenizal:8330/bug/term-agg-size-0 branch from fa12b92 to 4fefae1 Sep 20, 2016

@cjcenizal cjcenizal added the review label Sep 20, 2016

@spalger

This comment has been minimized.

Copy link
Member

spalger commented Sep 20, 2016

LGTM

1 similar comment
@jbudz

This comment has been minimized.

Copy link
Contributor

jbudz commented Sep 20, 2016

LGTM

@@ -155,7 +159,17 @@ uiModules
return searchSource.onResults().then(onResults);
}).catch(notify.fatal);

searchSource.onError(notify.error).catch(notify.fatal);
searchSource.onError(e => {
if (isTermSizeZeroError(e)) {

This comment has been minimized.

Copy link
@jbudz

jbudz Sep 20, 2016

Contributor

would it be possible to include vis titles for unknown errors too?

This comment has been minimized.

Copy link
@cjcenizal

cjcenizal Sep 20, 2016

Author Contributor

I like this idea, but it gets a little tricky given the implicit way our notification error messages are created. Let's address this as part of #8194

@cjcenizal cjcenizal merged commit d3ea495 into elastic:master Sep 20, 2016

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@cjcenizal cjcenizal deleted the cjcenizal:8330/bug/term-agg-size-0 branch Sep 20, 2016

@epixa epixa added the v5.0.0 label Sep 20, 2016

elastic-jasper added a commit that referenced this pull request Sep 20, 2016

Backport PR #8339
---------

**Commit 1:**
Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0.

- Display feedback if a Dashboard or Visualization is loaded that already violates this constraint.
- Add ElasticsearchError class and isTermSizeZeroError helper.

* Original sha: 4fefae1
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-19T19:02:54Z

elastic-jasper added a commit that referenced this pull request Sep 20, 2016

Backport PR #8339
---------

**Commit 1:**
Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0.

- Display feedback if a Dashboard or Visualization is loaded that already violates this constraint.
- Add ElasticsearchError class and isTermSizeZeroError helper.

* Original sha: 4fefae1
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-19T19:02:54Z

cjcenizal added a commit that referenced this pull request Sep 20, 2016

Merge pull request #8376 from elastic/jasper/backport/8339/5.x
[backport] PR #8339 to 5.x - Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0.

cjcenizal added a commit that referenced this pull request Sep 20, 2016

Merge pull request #8377 from elastic/jasper/backport/8339/5.0
[backport] PR #8339 to 5.0 - Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0.

@epixa epixa added v5.0.0-rc1 v5.0.0 and removed v5.0.0 labels Oct 7, 2016

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017

Backport PR elastic#8339
---------

**Commit 1:**
Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0.

- Display feedback if a Dashboard or Visualization is loaded that already violates this constraint.
- Add ElasticsearchError class and isTermSizeZeroError helper.

* Original sha: cd604dea0c6ffcb454c96e3ded5c00690d9af33c [formerly 4fefae1]
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-19T19:02:54Z


Former-commit-id: 0ca20ac

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017

Merge pull request elastic#8376 from elastic/jasper/backport/8339/5.x
[backport] PR elastic#8339 to 5.x - Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0.

Former-commit-id: a4df947

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

Backport PR elastic#8339
---------

**Commit 1:**
Set minimum aggregation 'Size' input value to 1, because ES will return an error if you provide a size of 0.

- Display feedback if a Dashboard or Visualization is loaded that already violates this constraint.
- Add ElasticsearchError class and isTermSizeZeroError helper.

* Original sha: 4fefae1
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-19T19:02:54Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.