Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 #84768

Merged
merged 5 commits into from Dec 15, 2020

Conversation

DianaDerevyankina
Copy link
Contributor

@DianaDerevyankina DianaDerevyankina commented Dec 2, 2020

Closes #84191

Summary

Fixed filtering by click on split gauge visualizations:

Gauge issue

Checklist

For maintainers

@DianaDerevyankina DianaDerevyankina added release_note:fix Feature:Gauge Vis Gauge and goal visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:UIActions UI actions. These are client side only, not related to the server side actions.. v7.11.0 labels Dec 2, 2020
@DianaDerevyankina DianaDerevyankina self-assigned this Dec 2, 2020
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! On attached screens I see that there are no labels for splitted data. But it's related to: #84764

@alexwizp alexwizp marked this pull request as ready for review December 2, 2020 16:53
@alexwizp alexwizp requested a review from a team December 2, 2020 16:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Tested locally, works as expected both for gauge and goal visualizations!

I noticed such a weird overlapping in gauge vis.. Are you able reproduce the same locally?

src/plugins/vis_type_vislib/public/vislib/visualizations/gauge_chart.js
image

I used kibana_sample_data_ecommerce index, split by Terms - category.keyword.
And I actually expect to see 5 gauges of each category, but see only 2. Seems to be bug!
Could you please check? If it is, an issue is worth to be created!

@stratoula
Copy link
Contributor

@sulemanof I can't reproduce it locally
image

@dziyanadzeraviankina thanx for this PR! It seems to work great but can you also add a functional test about this? It seems that we don't test filtering on gauge and it will be good to have it.

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanx @dziyanadzeraviankina for the functional test, it looks great now ❤️

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVislib 702.6KB 702.7KB +91.0B

Distributable file count

id before after diff
default 47129 47889 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeVislib 66.1KB 66.2KB +81.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@DianaDerevyankina DianaDerevyankina requested review from dmlemeshko and removed request for dmlemeshko December 15, 2020 08:01
@DianaDerevyankina DianaDerevyankina merged commit ffe29f7 into elastic:master Dec 15, 2020
gmmorris added a commit to ymao1/kibana that referenced this pull request Dec 15, 2020
* master: (66 commits)
  [Alerting] fixes broken Alerting Example plugin (elastic#85774)
  [APM] Service overview instances table (elastic#85770)
  [Security Solution] Unskip timeline creation Cypress test (elastic#85871)
  properly recognize enterprise licenses (elastic#85849)
  [SecuritySolution][Detections] Adds SavedObject persistence to Signals Migrations (elastic#85690)
  [TSVB] Fix functional tests flakiness and unskip them (elastic#85388)
  [Fleet] Change permissions for Fleet enroll role (elastic#85802)
  Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 (elastic#84768)
  [Security Solution][Detections] Add alert source to detection rule action context (elastic#85488)
  [Discover] Don't display hide/show button for histogram when there's no time filter (elastic#85424)
  skip flaky suite (elastic#78553)
  License checks for alerts plugin (elastic#85649)
  skip flaky suite (elastic#84992)
  skip 'query return results valid for scripted field' elastic#78553
  Allow action types to perform their own mustache variable escaping in parameter templates (elastic#83919)
  [ML] More machine learning links in doc_links_service.ts (elastic#85365)
  Removed Alerting & Event Log deprecated fields that should not be using (elastic#85652)
  Closes elastic#79995 by adding new tab in transaction details to show related trace logs. (elastic#85859)
  Fix outdated jest snapshot
  [Maps] Surface on prem EMS (elastic#85729)
  ...
alexwizp pushed a commit to alexwizp/kibana that referenced this pull request Dec 15, 2020
…e Kibana 7.10.0 (elastic#84768)

* Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0

Closes elastic#84191

* Add functional test to  filtering on gauge
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this pull request Dec 15, 2020
…e Kibana 7.10.0 (elastic#84768)

* Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0

Closes elastic#84191

* Add functional test to  filtering on gauge
alexwizp added a commit that referenced this pull request Dec 16, 2020
…e Kibana 7.10.0 (#84768) (#85938)

* Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0

Closes #84191

* Add functional test to  filtering on gauge

Co-authored-by: Diana Derevyankina <54894989+DziyanaDzeraviankina@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Gauge Vis Gauge and goal visualization Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0
6 participants