Setting up Presentation Util; Create Service Abstraction API

[clintandrewhall]

Summary

This PR completes a number of items:

• Creates the Plugin Services model for use in Presentation projects;
• Implements plugin services for the Presentation Utility plugin;
• Refactors components to use plugin-provided services, (rather than expect the consuming plugin to provide them);
• Adds Storybook to the Presentation Utility plugin;
• Documents all of the above.

Canvas has a bespoke method of providing simplified services to the plugin, (rather than consume useKibana or similar, which are notoriously difficult to track/mock). This PR extracts and improves upon that approach to be used in Dashboard, Canvas and elsewhere, (PR next). The net benefit is that plugins consuming Presentation Utility components don't need to provide full implementations of Kibana services, (particularly if they weren't present to begin with). In other words, there's no need to add savedObjects to the kibana.json for your plugin just to consume presentationUtil.

While working on the new service architecture, I added and refactored to provide Storybook to the Presentation Utility plugin.

I also took the opportunity to write docs using the new docs system, (a PR to add the items to the docs is forthcoming).

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[clintandrewhall]

@elasticmachine merge upstream

[tylersmalley]

Ops change looks good.

[crob611]

Looks like this is breaking in Kibana if you go to Lens and try to save in a way that will bring up the dashboard_picker

The error is that registry hasn't been set. Looks like it's because your presentation util plugin is providing a "getServices" method, but because the dashboard_picker accesses services directly, nothing is ever starting the services.

[crob611]

Left a few thoughts, and the issue with the plugins not being started needs to be resolved, but the code as a whole looks good. This is going to be great to build on going forward.

[stacey-gammon]

I love the concept, I'm just not sure if these interfaces/classes belong in the platform, or if we should consider this a recommended "best practice", and leave it up to each plugin author to build the service how they need.

[poffdeluxe]

Found a bug with the refactor of the modal but otherwise I'm fine with the setup

[crob611]

Looks good to me 👍

[stacey-gammon]

Love seeing more mdx docs!! I'll add the Team:Docs label so this gets included in the docs challenge. One thing though - can you nest this under the Services section and make Plugin services toolkit a section that is one part of the docs for the entire Presentation plugin? The plan is to have one entry per plugin, or if more breakdown is needed, do something like data.indexPatterns to break it up (this is how I'm planning on breaking up the API documentation system since some plugins are just way too big.

[elasticmachine]

Pinging @elastic/kibana-docs (Team:Docs)

[thomasneirynck]

maps/** lgtm!

[stratoula]

It seems that now savedObjectsClient it is not used for getTopNavConfig so no need to exist and it can be removed from the props here:

   export const getTopNavConfig = (
  {
    hasUnsavedChanges,
    setHasUnsavedChanges,
    openInspector,
    originatingApp,
    setOriginatingApp,
    hasUnappliedChanges,
    visInstance,
    stateContainer,
    savedObjectsClient,
    visualizationIdFromUrl,
    stateTransfer,
    embeddableId,
  }

It should be cleared from the visualize_top_nav.tsx too

[flash1293]

Lens changes LGTM

[kibanamachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: e488143
• Pipeline Steps (look for red circles / failed steps)
• Interpreting CI Failures

Failed CI Steps

• Setup Build Environment and Dependencies
• Setup Build Environment and Dependencies

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [96e4bdc]

History

• 💚 Build #101949 succeeded e488143
• 💚 Build #101613 succeeded 76eb940
• 💚 Build #101599 succeeded 862df19
• 💔 Build #101549 failed 7861086

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream