Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures we always select the correct index in UI tests #88876

Merged
merged 1 commit into from Jan 21, 2021

Conversation

gmmorris
Copy link
Contributor

@gmmorris gmmorris commented Jan 20, 2021

Summary

closes #88796

At times we find the driver controlling the ComboBox in our UI tests can select the wrong item, this ensures we always select the correct index in the Connector tests.

Flaky test run: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1133/

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@gmmorris gmmorris changed the title ensure we always select the correct index in UI tests Ensures we always select the correct index in UI tests Jan 20, 2021
@gmmorris gmmorris marked this pull request as ready for review January 20, 2021 20:29
@gmmorris gmmorris requested a review from a team as a code owner January 20, 2021 20:29
@gmmorris gmmorris added Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0 labels Jan 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmmorris gmmorris merged commit dfd96d6 into elastic:master Jan 21, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 21, 2021
At times we find the driver controlling the ComboBox in our UI tests can select the wrong item, this ensures we always select the correct index in the Connector tests.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added a commit that referenced this pull request Jan 21, 2021
At times we find the driver controlling the ComboBox in our UI tests can select the wrong item, this ensures we always select the correct index in the Connector tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Actions release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.12.0 v8.0.0
Projects
None yet
5 participants