[data.search.searchSource] Add fetch$ observable for partial results #89211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizozom
reviewed
Jan 26, 2021
lukasolson
added
Feature:Search
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
lukasolson
added
release_note:plugin_api_changes
lizozom
reviewed
Jan 27, 2021
| }) | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Fetch this source and reject the returned Promise on error | ||
| * |
There was a problem hiding this comment.
Should we maybe add @deprecated to this?
lizozom
reviewed
Jan 27, 2021
lizozom
reviewed
Jan 27, 2021
| @@ -305,16 +308,16 @@ export class SearchSource { | |||
| * Run a search using the search service | |||
There was a problem hiding this comment.
I think this block can be deleted from a private fn?
lizozom
approved these changes
Jan 27, 2021
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Jan 29, 2021
…lastic#89211) * [data.search.searchSource] Add fetch$ observable for partial results * Fix mocks & add tests * Update docs * Update docs * Review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #82887.
Adds a
fetch$method inSearchSourcethat enables consumers to get partial results instead of only the final response.Checklist
For maintainers
Plugin API Changes
The
datapluginsearchserviceSearchSourcenow provides afetch$method in addition to the existingfetchmethod that returns anObservableover all responses returned. This is useful when_async_searchis being used and the consumer needs to handle partial search responses.