From 9e6ff3c3587cf42c9a677e94e0d5fdb06dd96435 Mon Sep 17 00:00:00 2001
From: nreese <reese.nathan@gmail.com>
Date: Wed, 2 Nov 2016 16:45:36 -0600
Subject: [PATCH 1/2] show search bar in embedded dashboards and visualizations

---
 .../kibana/public/dashboard/index.html          |  2 +-
 .../kibana/public/visualize/editor/editor.html  |  2 +-
 src/ui/public/chrome/api/controls.js            | 17 +++++++++++++++++
 src/ui/public/chrome/directives/kbn_chrome.js   |  3 +++
 src/ui/public/kbn_top_nav/kbn_top_nav.html      |  2 +-
 .../kbn_top_nav/kbn_top_nav_controller.js       |  6 +++++-
 src/ui/public/share/directives/share.js         |  4 +++-
 src/ui/public/share/views/share.html            | 14 ++++++++++++++
 8 files changed, 45 insertions(+), 5 deletions(-)

diff --git a/src/core_plugins/kibana/public/dashboard/index.html b/src/core_plugins/kibana/public/dashboard/index.html
index e1b29a59c5c7b1..85bbc8b6926035 100644
--- a/src/core_plugins/kibana/public/dashboard/index.html
+++ b/src/core_plugins/kibana/public/dashboard/index.html
@@ -18,7 +18,7 @@
       <form
         data-transclude-slot="bottomRow"
         class="fullWidth"
-        ng-show="chrome.getVisible()"
+        ng-show="chrome.getShowSearch()"
         role="form"
         name="queryInput"
         ng-submit="filterResults()"
diff --git a/src/core_plugins/kibana/public/visualize/editor/editor.html b/src/core_plugins/kibana/public/visualize/editor/editor.html
index f0547cbe8e87a3..2b466cdf7802ce 100644
--- a/src/core_plugins/kibana/public/visualize/editor/editor.html
+++ b/src/core_plugins/kibana/public/visualize/editor/editor.html
@@ -17,7 +17,7 @@
       <!-- Search. -->
       <div
         data-transclude-slot="bottomRow"
-        ng-show="chrome.getVisible()"
+        ng-show="chrome.getShowSearch()"
         class="fullWidth"
       >
         <!-- Block searching if the Visualization is linked to a Saved Search. -->
diff --git a/src/ui/public/chrome/api/controls.js b/src/ui/public/chrome/api/controls.js
index 93408b9c682d44..9c8031d2875c6b 100644
--- a/src/ui/public/chrome/api/controls.js
+++ b/src/ui/public/chrome/api/controls.js
@@ -29,4 +29,21 @@ module.exports = function (chrome, internals) {
     if (_.isUndefined(internals.visible)) return def;
     return internals.visible;
   };
+
+  /**
+   * @param {boolean} showSearch - should the chrome Search Bar be displayed
+   * @return {chrome}
+   */
+  chrome.setShowSearch = function (showSearch) {
+    internals.showSearch = Boolean(showSearch);
+    return chrome;
+  };
+
+  /**
+   * @return {boolean} - Show Search Bar state of the chrome
+   */
+  chrome.getShowSearch = function () {
+    if (_.isUndefined(internals.showSearch)) return true;
+    return internals.showSearch;
+  };
 };
diff --git a/src/ui/public/chrome/directives/kbn_chrome.js b/src/ui/public/chrome/directives/kbn_chrome.js
index 1b191dda6809a1..f37e106ac3da4c 100644
--- a/src/ui/public/chrome/directives/kbn_chrome.js
+++ b/src/ui/public/chrome/directives/kbn_chrome.js
@@ -37,6 +37,9 @@ export default function (chrome, internals) {
 
         // are we showing the embedded version of the chrome?
         internals.setVisibleDefault(!$location.search().embed);
+        if ($location.search().embed) {
+          chrome.setShowSearch($location.search().showSearch);
+        }
 
         // listen for route changes, propogate to tabs
         const onRouteChange = function () {
diff --git a/src/ui/public/kbn_top_nav/kbn_top_nav.html b/src/ui/public/kbn_top_nav/kbn_top_nav.html
index 5ec6577c825d65..796aaa66bfd63f 100644
--- a/src/ui/public/kbn_top_nav/kbn_top_nav.html
+++ b/src/ui/public/kbn_top_nav/kbn_top_nav.html
@@ -4,7 +4,7 @@
   data-test-subj="top-nav"
 >
   <!-- Top row -->
-  <div class="localNavRow">
+  <div class="localNavRow" ng-show="!kbnTopNav.isEmbedded()">
     <!-- Top left corner slot, e.g. breadcrumbs, title. -->
     <div
       class="localNavRow__section"
diff --git a/src/ui/public/kbn_top_nav/kbn_top_nav_controller.js b/src/ui/public/kbn_top_nav/kbn_top_nav_controller.js
index 4e8e6577881cc2..6c6a40810323df 100644
--- a/src/ui/public/kbn_top_nav/kbn_top_nav_controller.js
+++ b/src/ui/public/kbn_top_nav/kbn_top_nav_controller.js
@@ -23,7 +23,11 @@ export default function ($compile) {
     }
 
     isVisible() {
-      return chrome.getVisible();
+      return chrome.getVisible() || chrome.getShowSearch();
+    }
+
+    isEmbedded() {
+      return !chrome.getVisible();
     }
 
     addItems(rawOpts) {
diff --git a/src/ui/public/share/directives/share.js b/src/ui/public/share/directives/share.js
index b5fdefee05bb5f..15e0c16decdd56 100644
--- a/src/ui/public/share/directives/share.js
+++ b/src/ui/public/share/directives/share.js
@@ -74,7 +74,8 @@ app.directive('share', function (Private) {
       }
 
       this.makeUrlEmbeddable = url => {
-        const embedQueryParam = '?embed=true';
+        let embedQueryParam = '?embed=true';
+        if (this.showSearch) embedQueryParam += '&showSearch=true';
         const urlHasQueryString = url.indexOf('?') !== -1;
         if (urlHasQueryString) {
           return url.replace('?', `${embedQueryParam}&`);
@@ -115,6 +116,7 @@ app.directive('share', function (Private) {
           shortSnapshotIframe: false,
         };
       };
+      $scope.updateUrls = updateUrls;
 
       // When the URL changes, update the links in the UI.
       $scope.$watch(() => $location.absUrl(), () => {
diff --git a/src/ui/public/share/views/share.html b/src/ui/public/share/views/share.html
index f43efa2d511a0a..c7bb3801c01466 100644
--- a/src/ui/public/share/views/share.html
+++ b/src/ui/public/share/views/share.html
@@ -36,6 +36,13 @@
           </div>
         </div>
 
+        <div>
+          <label>
+            <input type="checkbox" ng-model="share.showSearch" name="showSearch" ng-change="updateUrls()">
+            Show Search Bar
+          </label>
+        </div>
+
         <!-- Input -->
         <input
           id="originalIframeUrl"
@@ -125,6 +132,13 @@
         </div>
       </div>
 
+      <div>
+        <label>
+          <input type="checkbox" ng-model="share.showSearch" name="showSearch" ng-change="updateUrls()">
+          Show Search Bar
+        </label>
+      </div>
+
       <!-- Input -->
       <input
         id="snapshotIframeUrl"

From e661b59aead2bbe20fd6ed7d03ba78d9cae926db Mon Sep 17 00:00:00 2001
From: nreese <reese.nathan@gmail.com>
Date: Wed, 2 Nov 2016 16:50:26 -0600
Subject: [PATCH 2/2] use this instead of  for method updateUrls

---
 src/ui/public/share/directives/share.js | 2 +-
 src/ui/public/share/views/share.html    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/ui/public/share/directives/share.js b/src/ui/public/share/directives/share.js
index 15e0c16decdd56..4759d1f0b202b2 100644
--- a/src/ui/public/share/directives/share.js
+++ b/src/ui/public/share/directives/share.js
@@ -116,7 +116,7 @@ app.directive('share', function (Private) {
           shortSnapshotIframe: false,
         };
       };
-      $scope.updateUrls = updateUrls;
+      this.updateUrls = updateUrls;
 
       // When the URL changes, update the links in the UI.
       $scope.$watch(() => $location.absUrl(), () => {
diff --git a/src/ui/public/share/views/share.html b/src/ui/public/share/views/share.html
index c7bb3801c01466..31efca77e91035 100644
--- a/src/ui/public/share/views/share.html
+++ b/src/ui/public/share/views/share.html
@@ -38,7 +38,7 @@
 
         <div>
           <label>
-            <input type="checkbox" ng-model="share.showSearch" name="showSearch" ng-change="updateUrls()">
+            <input type="checkbox" ng-model="share.showSearch" name="showSearch" ng-change="share.updateUrls()">
             Show Search Bar
           </label>
         </div>
@@ -134,7 +134,7 @@
 
       <div>
         <label>
-          <input type="checkbox" ng-model="share.showSearch" name="showSearch" ng-change="updateUrls()">
+          <input type="checkbox" ng-model="share.showSearch" name="showSearch" ng-change="share.updateUrls()">
           Show Search Bar
         </label>
       </div>