Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes "global-style" setting for npm #9256

Merged
merged 1 commit into from Nov 29, 2016

Conversation

@epixa
Copy link
Member

commented Nov 29, 2016

This change, which was originally introduced in #9136, resulted in much
larger installs for Kibana (50MB larger in dev mode), which isn't a
reasonable tradeoff for the convenience that global-style provides.

Removes "global-style" setting for npm
This change, which was originally introduced in #9136, resulted in much
larger installs for Kibana (50MB larger in dev mode), which isn't a
reasonable tradeoff for the convenience that global-style provides.
@spalger
Copy link
Member

left a comment

LGTM

@epixa epixa merged commit 4d6e0d7 into elastic:master Nov 29, 2016

1 check passed

kibana-ci Build finished.
Details

@epixa epixa deleted the epixa:revert-npm-globalstyle branch Nov 29, 2016

elastic-jasper added a commit that referenced this pull request Nov 29, 2016
Removes "global-style" setting for npm
Backports PR #9256

**Commit 1:**
Removes "global-style" setting for npm

This change, which was originally introduced in #9136, resulted in much
larger installs for Kibana (50MB larger in dev mode), which isn't a
reasonable tradeoff for the convenience that global-style provides.

* Original sha: bdf4c68
* Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
elastic-jasper added a commit that referenced this pull request Nov 29, 2016
Removes "global-style" setting for npm
Backports PR #9256

**Commit 1:**
Removes "global-style" setting for npm

This change, which was originally introduced in #9136, resulted in much
larger installs for Kibana (50MB larger in dev mode), which isn't a
reasonable tradeoff for the convenience that global-style provides.

* Original sha: bdf4c68
* Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
epixa added a commit that referenced this pull request Nov 29, 2016
Removes "global-style" setting for npm (#9258)
Backports PR #9256

**Commit 1:**
Removes "global-style" setting for npm

This change, which was originally introduced in #9136, resulted in much
larger installs for Kibana (50MB larger in dev mode), which isn't a
reasonable tradeoff for the convenience that global-style provides.

* Original sha: bdf4c68
* Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
epixa added a commit that referenced this pull request Nov 29, 2016
Removes "global-style" setting for npm (#9259)
Backports PR #9256

**Commit 1:**
Removes "global-style" setting for npm

This change, which was originally introduced in #9136, resulted in much
larger installs for Kibana (50MB larger in dev mode), which isn't a
reasonable tradeoff for the convenience that global-style provides.

* Original sha: bdf4c68
* Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z

@ppisljar ppisljar added the backported label Dec 2, 2016

@epixa epixa added v5.1.1 and removed v5.1.1 v5.1.0 labels Dec 8, 2016

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
Removes "global-style" setting for npm (elastic#9259)
Backports PR elastic#9256

**Commit 1:**
Removes "global-style" setting for npm

This change, which was originally introduced in elastic#9136, resulted in much
larger installs for Kibana (50MB larger in dev mode), which isn't a
reasonable tradeoff for the convenience that global-style provides.

* Original sha: bdf4c68
* Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z

Former-commit-id: 9b43bdc
Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017
Removes "global-style" setting for npm (elastic#9258)
Backports PR elastic#9256

**Commit 1:**
Removes "global-style" setting for npm

This change, which was originally introduced in elastic#9136, resulted in much
larger installs for Kibana (50MB larger in dev mode), which isn't a
reasonable tradeoff for the convenience that global-style provides.

* Original sha: bdf4c68
* Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.