Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] DataFrame Analytics models: ensure 'View training data' link activates quick filter in exploration page #93071

Merged
merged 1 commit into from Mar 2, 2021
Merged

[ML] DataFrame Analytics models: ensure 'View training data' link activates quick filter in exploration page #93071

merged 1 commit into from Mar 2, 2021

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Mar 1, 2021 •
edited

Summary

Fixes #87982

Updates filter regex pattern to match when there are

  • no spaces between the text and semicolon
  • one space between text and semicolon
  • multiple spaces between text and semicolon

Checklist

Delete any items that are not applicable to this PR.

  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@alvarezmelissa87 alvarezmelissa87 self-assigned this Mar 1, 2021
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner March 1, 2021 17:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Mar 1, 2021

Tested and LGTM 🎉

walterra
walterra approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just wondering why this changes the bundle size of triggersActionsUi in the build summary, maybe needs a remerge?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.4MB 6.4MB +4.0B
triggersActionsUi 1.6MB 1.5MB -23.9KB
total -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit 36523bb into elastic:master Mar 2, 2021
This was referenced Mar 2, 2021
Merged
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Mar 2, 2021
@alvarezmelissa87
ensure regex works for filter with optional multiple spaces (elastic#…
268c010 
…93071)
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-fix-training-filter branch March 2, 2021 20:45
alvarezmelissa87 added a commit that referenced this pull request Mar 2, 2021
@alvarezmelissa87
ensure regex works for filter with optional multiple spaces (#93071) (#…
37c0dd0 
…93314)
alvarezmelissa87 added a commit that referenced this pull request Mar 2, 2021
@alvarezmelissa87
ensure regex works for filter with optional multiple spaces (#93071) (#…
2f0212f 
…93313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] DFA models - view training data link doesn't activate quick filter
5 participants
@alvarezmelissa87 @elasticmachine @qn895 @kibanamachine @walterra