New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce expanded dashboard panel mode #9666

Merged
merged 2 commits into from Jan 3, 2017

Conversation

Projects
None yet
4 participants
@Stacey-Gammon
Contributor

Stacey-Gammon commented Dec 28, 2016

As mentioned in #7917 and #3725 a "maximize" dashboard panel setting would be helpful to let users quickly "zoom in" on a particular panel.

The setting is not saved in state, so refreshing the page will close any expanded panel. If the user wants a static dashboard with a single visualization, they can create one and I envision this feature being mainly used temporarily.

Screenshots:
screen shot 2016-12-28 at 12 04 17 pm
screen shot 2016-12-28 at 12 04 24 pm

Animated gif:
expandcollapse

Open Questions

  • Once we introduce view/edit mode, should the setting be available in both? I think yes because it's a view setting - you want to see more data on a particular visualization. The down side is that we end up having buttons showing up on hover again, which is somewhat visually distracting. Another option is to hide the button and make double click do zoom-in/zoom-out as suggested in one of the comments in #3725.
  • Should the option be available in embedded mode. I'm thinking yes, since it's a visual-only thing.

@Stacey-Gammon Stacey-Gammon requested review from kobelb and cjcenizal Dec 28, 2016

@Stacey-Gammon

This comment has been minimized.

Show comment
Hide comment
@Stacey-Gammon

Stacey-Gammon Dec 29, 2016

Contributor

jenkins test this (looks like the build was aborted)

Contributor

Stacey-Gammon commented Dec 29, 2016

jenkins test this (looks like the build was aborted)

@Stacey-Gammon

This comment has been minimized.

Show comment
Hide comment
@Stacey-Gammon

Stacey-Gammon Dec 29, 2016

Contributor

Second test failure looks not related either:

ERROR: Build step failed with exception
com.amazonaws.SdkClientException: Unable to execute HTTP request: java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:972)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:676)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:650)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:633)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$300(AmazonHttpClient.java:601)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:583)
	at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:447)
	at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4137)
	at com.amazonaws.services.s3.AmazonS3Client.putObject(AmazonS3Client.java:1685)
	at com.amazonaws.services.s3.transfer.internal.UploadCallable.uploadInOneChunk(UploadCallable.java:133)
	at com.amazonaws.services.s3.transfer.internal.UploadCallable.call(UploadCallable.java:125)
	at com.amazonaws.services.s3.transfer.internal.UploadMonitor.call(UploadMonitor.java:139)
	at com.amazonaws.services.s3.transfer.internal.UploadMonitor.call(UploadMonitor.java:47)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
	at ......remote call to Channel to /10.34.148.136(Native Method)
	at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1537)
	at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
	at hudson.remoting.Channel.call(Channel.java:822)
	at hudson.FilePath.act(FilePath.java:985)
	at hudson.FilePath.act(FilePath.java:974)
	at hudson.plugins.s3.S3Profile.invoke(S3Profile.java:201)
	at hudson.plugins.s3.S3Profile.waitUploads(S3Profile.java:195)
	at hudson.plugins.s3.S3Profile.upload(S3Profile.java:174)
	at hudson.plugins.s3.S3BucketPublisher.perform(S3BucketPublisher.java:198)
	at hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:78)
	at hudson.tasks.BuildStepMonitor$2.perform(BuildStepMonitor.java:32)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
	at hudson.model.Build$BuildExecution.post2(Build.java:185)
	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:665)
	at hudson.model.Run.execute(Run.java:1754)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:98)
	at hudson.model.Executor.run(Executor.java:404)
Caused by: javax.net.ssl.SSLException: java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty

jenkins test this

Contributor

Stacey-Gammon commented Dec 29, 2016

Second test failure looks not related either:

ERROR: Build step failed with exception
com.amazonaws.SdkClientException: Unable to execute HTTP request: java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:972)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:676)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:650)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:633)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$300(AmazonHttpClient.java:601)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:583)
	at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:447)
	at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4137)
	at com.amazonaws.services.s3.AmazonS3Client.putObject(AmazonS3Client.java:1685)
	at com.amazonaws.services.s3.transfer.internal.UploadCallable.uploadInOneChunk(UploadCallable.java:133)
	at com.amazonaws.services.s3.transfer.internal.UploadCallable.call(UploadCallable.java:125)
	at com.amazonaws.services.s3.transfer.internal.UploadMonitor.call(UploadMonitor.java:139)
	at com.amazonaws.services.s3.transfer.internal.UploadMonitor.call(UploadMonitor.java:47)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
	at ......remote call to Channel to /10.34.148.136(Native Method)
	at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1537)
	at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
	at hudson.remoting.Channel.call(Channel.java:822)
	at hudson.FilePath.act(FilePath.java:985)
	at hudson.FilePath.act(FilePath.java:974)
	at hudson.plugins.s3.S3Profile.invoke(S3Profile.java:201)
	at hudson.plugins.s3.S3Profile.waitUploads(S3Profile.java:195)
	at hudson.plugins.s3.S3Profile.upload(S3Profile.java:174)
	at hudson.plugins.s3.S3BucketPublisher.perform(S3BucketPublisher.java:198)
	at hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:78)
	at hudson.tasks.BuildStepMonitor$2.perform(BuildStepMonitor.java:32)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
	at hudson.model.Build$BuildExecution.post2(Build.java:185)
	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:665)
	at hudson.model.Run.execute(Run.java:1754)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:98)
	at hudson.model.Executor.run(Executor.java:404)
Caused by: javax.net.ssl.SSLException: java.lang.RuntimeException: Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty

jenkins test this

@kobelb

This comment has been minimized.

Show comment
Hide comment
@kobelb

kobelb Jan 2, 2017

Contributor

I really like this.

I think having this available in both view/edit/embed mode is beneficial.

Contributor

kobelb commented Jan 2, 2017

I really like this.

I think having this available in both view/edit/embed mode is beneficial.

@kobelb

kobelb approved these changes Jan 2, 2017

LGTM

@cjcenizal

Looks awesome! Just had a couple suggestions.

I also think this will be useful in both edit and embedded modes.

@Stacey-Gammon

This comment has been minimized.

Show comment
Hide comment
@Stacey-Gammon

Stacey-Gammon Jan 3, 2017

Contributor

@cjcenizal all changes should be addressed, thanks!

Contributor

Stacey-Gammon commented Jan 3, 2017

@cjcenizal all changes should be addressed, thanks!

@cjcenizal

LGTM!

@Stacey-Gammon Stacey-Gammon merged commit 26561e7 into elastic:master Jan 3, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

elastic-jasper added a commit that referenced this pull request Jan 3, 2017

Introduce expanded dashboard panel mode
Backports PR #9666

**Commit 1:**
Introduce expanded dashboard panel mode

* Original sha: 9200cb1
* Authored by Stacey Gammon <gammon@elastic.co> on 2016-12-28T17:02:17Z

**Commit 2:**
address code review comments

* Original sha: e3a8cae
* Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-03T16:06:18Z

@Stacey-Gammon Stacey-Gammon added the v5.2.0 label Jan 3, 2017

Stacey-Gammon added a commit that referenced this pull request Jan 3, 2017

Introduce expanded dashboard panel mode (#9706)
Backports PR #9666

**Commit 1:**
Introduce expanded dashboard panel mode

* Original sha: 9200cb1
* Authored by Stacey Gammon <gammon@elastic.co> on 2016-12-28T17:02:17Z

**Commit 2:**
address code review comments

* Original sha: e3a8cae
* Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-03T16:06:18Z

@epixa epixa added v5.3.0 and removed v5.2.0 labels Mar 27, 2017

@Stacey-Gammon Stacey-Gammon deleted the Stacey-Gammon:expand-panel branch Apr 6, 2017

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

Introduce expanded dashboard panel mode (#9706)
Backports PR #9666

**Commit 1:**
Introduce expanded dashboard panel mode

* Original sha: 9200cb1
* Authored by Stacey Gammon <gammon@elastic.co> on 2016-12-28T17:02:17Z

**Commit 2:**
address code review comments

* Original sha: e3a8cae
* Authored by Stacey Gammon <gammon@elastic.co> on 2017-01-03T16:06:18Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment