Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build configuration to run on Windows machines #9951

Merged
merged 1 commit into from Jan 19, 2017

Conversation

pickypg
Copy link
Member

@pickypg pickypg commented Jan 18, 2017

This checks for Windows machines and runs a slower variant to get the build number.

I am going to backport this to every 5.x branch for convenience.

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't think the condition is necessary, but looks good and works for me

@pickypg pickypg merged commit 8029e04 into elastic:master Jan 19, 2017
@pickypg pickypg deleted the fix/run-tasks-on-windows branch January 19, 2017 04:18
@pickypg
Copy link
Member Author

pickypg commented Jan 19, 2017

5.3: 10f4277
5.2: a0455ed
5.1: ee13cc9
5.0: 5c0efb9

airow added a commit to airow/kibana that referenced this pull request Jan 22, 2017
airow added a commit to airow/kibana that referenced this pull request Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants