New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow saved objects to have orderable fields with a fieldOrder property #9992

Merged
merged 2 commits into from Feb 2, 2017

Conversation

Projects
None yet
5 participants
@coverslide
Contributor

coverslide commented Jan 21, 2017

Fixes #9334. This pushes the title and description fields to the top of the saved object pages.

@elasticmachine

This comment has been minimized.

Show comment
Hide comment
@elasticmachine

elasticmachine Jan 21, 2017

Can one of the admins verify this patch?

elasticmachine commented Jan 21, 2017

Can one of the admins verify this patch?

@coverslide

This comment has been minimized.

Show comment
Hide comment
@coverslide

coverslide Jan 26, 2017

Contributor

Is there for me to have this tested @epixa? Thanks.

Contributor

coverslide commented Jan 26, 2017

Is there for me to have this tested @epixa? Thanks.

@epixa

This comment has been minimized.

Show comment
Hide comment
@epixa

epixa Jan 26, 2017

Member

@coverslide Sorry for the delay here

Member

epixa commented Jan 26, 2017

@coverslide Sorry for the delay here

@epixa

This comment has been minimized.

Show comment
Hide comment
@epixa

epixa Jan 26, 2017

Member

jenkins, test this

Member

epixa commented Jan 26, 2017

jenkins, test this

@coverslide

This comment has been minimized.

Show comment
Hide comment
@coverslide

coverslide Jan 26, 2017

Contributor

@epixa Thank you. I appreciate it.

Contributor

coverslide commented Jan 26, 2017

@epixa Thank you. I appreciate it.

@coverslide

This comment has been minimized.

Show comment
Hide comment
@coverslide

coverslide Jan 27, 2017

Contributor

@epixa can you please retest? I ran locally and was unable to duplicate so may just be selenium.

Contributor

coverslide commented Jan 27, 2017

@epixa can you please retest? I ran locally and was unable to duplicate so may just be selenium.

@epixa

This comment has been minimized.

Show comment
Hide comment
@epixa

epixa Jan 27, 2017

Member

jenkins, test this

Member

epixa commented Jan 27, 2017

jenkins, test this

@coverslide

This comment has been minimized.

Show comment
Hide comment
@coverslide
Contributor

coverslide commented Jan 27, 2017

@ycombinator ycombinator self-requested a review Jan 30, 2017

@ycombinator ycombinator self-assigned this Jan 30, 2017

@ycombinator

This comment has been minimized.

Show comment
Hide comment
@ycombinator

ycombinator Jan 30, 2017

Contributor

@coverslide Thanks for the PR and apologies for the delay. I plan to review this today or tomorrow.

Contributor

ycombinator commented Jan 30, 2017

@coverslide Thanks for the PR and apologies for the delay. I plan to review this today or tomorrow.

@ycombinator

Functionality looks good. I left a minor comment on the code about adding a clarifying comment. Once that is done, I'll give my 👍.

Thanks @coverslide!

@coverslide

This comment has been minimized.

Show comment
Hide comment
@coverslide

coverslide Jan 31, 2017

Contributor

@ycombinator updated!

Contributor

coverslide commented Jan 31, 2017

@ycombinator updated!

@ycombinator

LGTM! Thanks for the contribution @coverslide.

@ycombinator

This comment has been minimized.

Show comment
Hide comment
@ycombinator

ycombinator Jan 31, 2017

Contributor

@thomasneirynck Could you be 2nd reviewed on this, as you filed the issue this PR addresses? Thanks!

Contributor

ycombinator commented Jan 31, 2017

@thomasneirynck Could you be 2nd reviewed on this, as you filed the issue this PR addresses? Thanks!

@ycombinator ycombinator merged commit 3251c99 into elastic:master Feb 2, 2017

1 check passed

CLA Commit author has signed the CLA
Details

ycombinator added a commit to ycombinator/kibana that referenced this pull request Feb 2, 2017

Allow saved objects to have orderable fields with a fieldOrder proper…
…ty (#9992)

* Allow saved objects to have orderable fields with a fieldOrder property

* Add clarification for fieldOrder param for saved objects
@ycombinator

This comment has been minimized.

Show comment
Hide comment
@ycombinator

ycombinator Feb 2, 2017

Contributor

Backported to:

Contributor

ycombinator commented Feb 2, 2017

Backported to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment