New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher Preprocessor Logic Change #207

Merged
merged 1 commit into from Oct 26, 2015

Conversation

Projects
None yet
3 participants
@andrewkroh
Member

andrewkroh commented Oct 23, 2015

Change logic used by the publisher's preprocessor for determining whether to use message.event or message.events. This change allows the preprocessor to function correctly in the case that a client publishes an empty message.events. It also makes the logic consistent with other parts of the code like bulk.go.

I discovered that if I sent an empty events slice that the processor would complain about a "Missing 'timestamp' field from event" because it tried to send message.event.

@andrewkroh andrewkroh added the bug label Oct 23, 2015

@elasticsearch-release

This comment has been minimized.

elasticsearch-release commented Oct 23, 2015

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@ruflin

This comment has been minimized.

Contributor

ruflin commented Oct 26, 2015

@andrewkroh Can you add it to the CHANGELOG.md?

Change logic used by the publisher's preprocessor for determining whe…
…ther to use message.event or message.events. This change allows the preprocessor to function correctly in the case that a client publishes an empty message.events. It also makes the logic consistent with other parts of the code like bulk.go.

I discovered that if I sent an empty events slice that the processor would complain about a "Missing 'timestamp' field from event".
@andrewkroh

This comment has been minimized.

Member

andrewkroh commented Oct 26, 2015

I updated the changelog for this PR.

ruflin added a commit that referenced this pull request Oct 26, 2015

@ruflin ruflin merged commit 99ab3f7 into elastic:master Oct 26, 2015

2 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@andrewkroh andrewkroh deleted the andrewkroh:bugfix/preprocessor-logic branch Nov 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment