Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing enabled as a configuration option for outputs. #295

Merged

Conversation

Projects
None yet
4 participants
@andrewkroh
Copy link
Member

commented Nov 12, 2015

Removing disabled as a configuration opation for tls configuration.
Use comments in config file to enable and disable. #264

Suggested diff view: Ignore trailing whitespace (the docs had a lot of trailing whitespace)

Removing enabled as a configuration option for outputs.
Removing disabled as a configuration opation for tls configuration.
Use comments in config file to enable and disable. #264
@elasticsearch-release

This comment has been minimized.

Copy link

commented Nov 12, 2015

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@andrewkroh andrewkroh added the review label Nov 12, 2015

@urso

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2015

LGTM

@ruflin

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2015

LGTM.

It's good that you marked it as BC break as one issue I see popping up, is that some users will have uncommented the output lines and as enabled / disabled is not relevant anymore, it will active the output. We should elaborate on that in the release blog post.

ruflin added a commit that referenced this pull request Nov 13, 2015

Merge pull request #295 from andrewkroh/feature/config-remove-enabled…
…-disabled

Removing enabled as a configuration option for outputs.

@ruflin ruflin merged commit d9c6ab2 into elastic:master Nov 13, 2015

2 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@andrewkroh andrewkroh deleted the andrewkroh:feature/config-remove-enabled-disabled branch Dec 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.