New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error and log handling #305

Merged
merged 1 commit into from Nov 16, 2015

Conversation

Projects
None yet
4 participants
@ruflin
Contributor

ruflin commented Nov 16, 2015

No description provided.

@elasticsearch-release

This comment has been minimized.

Show comment
Hide comment
@elasticsearch-release

elasticsearch-release Nov 16, 2015

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

elasticsearch-release commented Nov 16, 2015

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@ruflin ruflin changed the title from Disable geoip by default to Improve error and log handling Nov 16, 2015

@@ -10,8 +10,8 @@ All notable changes to this project will be documented in this file based on the
- Use of `enabled` as a configuration option for outputs (elasticsearch,
logstash, etc.) has been removed. #264
- Use of `disabled` as a configuration option for tls has been removed. #264
- The `shipper` output field is renamed to `beat.name`. #285

This comment has been minimized.

@andrewkroh

andrewkroh Nov 16, 2015

Member

Why is this being removed here?

@andrewkroh

andrewkroh Nov 16, 2015

Member

Why is this being removed here?

This comment has been minimized.

@ruflin

ruflin Nov 16, 2015

Contributor

It is still there (look at line 9). It was a duplicate.

@ruflin

ruflin Nov 16, 2015

Contributor

It is still there (look at line 9). It was a duplicate.

Show outdated Hide outdated beat/beat.go
Show outdated Hide outdated common/geolite.go
Show outdated Hide outdated common/geolite.go
Improve error and log handling
* Disable geoip by default
* Move disabling of stderr disabling to load config so no messages when starting up from console by default
* Improve what is logged to info and what to debug

andrewkroh added a commit that referenced this pull request Nov 16, 2015

Merge pull request #305 from ruflin/geoip-logging
Improve error and log handling

@andrewkroh andrewkroh merged commit 21595f2 into elastic:master Nov 16, 2015

2 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment