New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent file system permissions #113

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@akostadinov

akostadinov commented Nov 17, 2018

Removing redundant chmod line as well making config files same mode as
the rest of the directory. This helps container runtimes that run with a
randomly generated user id but root group (openshift/kubernetes) to
directly run this image without modifications.

akostadinov added some commits Nov 17, 2018

@jarpy

This comment has been minimized.

Contributor

jarpy commented Nov 19, 2018

Good call. We should also explicitly add the process user to the root group, like we do for Elasticsearch and add tests for both changes.

If you're happy to sign CLA I can merge this right away. If you'd like to add some of the things mentioned above, that's fantastic!

@akostadinov

This comment has been minimized.

akostadinov commented Nov 19, 2018

I'm checking whether I can sign and in what capacity but not sure when I will know. I don't think one line removed and one line copied from another place in the same file can constitute copyrights. If you like submit your own pull request and close this one, might be easier than wait for my CLA.

And tbh with an apache 2 license I see no point in having a CLA for this repo. I would understand if it was GPL or something else copyleft. For apache 2 you can do with contributions almost anything anyway.

@jarpy

This comment has been minimized.

Contributor

jarpy commented Nov 20, 2018

I understand. Sorry for the trouble. I'm an engineer, not a lawyer. I just know that I'm supposed to ask. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment