Browse files

- add todo

  • Loading branch information...
1 parent c401c0a commit c1ce8e52cebcb960ad859a0f11e4c9bddb2ba966 @jordansissel jordansissel committed Feb 12, 2013
Showing with 5 additions and 0 deletions.
  1. +5 −0 lib/lumberjack/server.rb
View
5 lib/lumberjack/server.rb
@@ -212,6 +212,11 @@ def initialize(fd)
def run(&block)
while true
+ # TODO(sissel): Ack on idle.
+ # X: - if any unacked, IO.select
+ # X: - on timeout, ack all.
+ # X: Doing so will prevent slow streams from retransmitting
+ # X: too many events after errors.
@parser.feed(@fd.sysread(16384)) do |event, *args|
case event
when :window_size; window_size(*args, &block)

0 comments on commit c1ce8e5

Please sign in to comment.